fix(create-new-release.yml): update client-payload to use github.ref_… #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name instead of github.ref to correctly reference the branch name feat(publish-docker-image.yml): add support for specifying a custom tag when triggering the workflow manually The client-payload in create-new-release.yml is updated to use github.ref_name instead of github.ref to ensure the correct branch name is used. In publish-docker-image.yml, support is added for specifying a custom tag when manually triggering the workflow using workflow_dispatch. This allows users to provide a specific tag for the Docker image build and push process.
mauvehed
added
ci
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @mauvehed - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| tags: ghcr.io/${{ github.repository_owner }}/yourip:nightly | ||
| - name: Build and push Docker image | ||
| run: | | ||
| TAG="${{ github.event.client_payload.tag || github.event.inputs.tag }}" |
There was a problem hiding this comment.
issue (bug_risk): Potential issue with tag extraction.
The expression ${{ github.event.client_payload.tag || github.event.inputs.tag }} might not work as expected if github.event.client_payload.tag is an empty string. Consider using a more explicit check.
| exit 1 | ||
| fi | ||
|
|
||
| if [ "${TAG}" = "nightly" ]; then |
There was a problem hiding this comment.
suggestion: Use double brackets for string comparison.
Using double brackets [[ ... ]] for string comparison is generally safer and more robust in shell scripts.
Suggested change
| if [ "${TAG}" = "nightly" ]; then | |
| if [[ "${TAG}" == "nightly" ]]; then |
…test image based on the TAG value The workflow file now includes a conditional statement to build and push a test image to the GitHub Container Registry (GHCR) when the TAG value is set to "test". This enhancement allows for better testing and validation of the application in a separate environment before deploying to production.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
…ic for better readability and maintainability The TAG variable assignment logic has been refactored to improve readability and maintainability. The script now sets the TAG variable based on the event type (repository_dispatch, workflow_dispatch, push) and commit message content. This change makes it easier to understand how the TAG is determined in different scenarios, ensuring consistent behavior across events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…name instead of github.ref to correctly reference the branch name
feat(publish-docker-image.yml): add support for specifying a custom tag when triggering the workflow manually The client-payload in create-new-release.yml is updated to use github.ref_name instead of github.ref to ensure the correct branch name is used. In publish-docker-image.yml, support is added for specifying a custom tag when manually triggering the workflow using workflow_dispatch. This allows users to provide a specific tag for the Docker image build and push process.