-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(create-new-release.yml): update client-payload to use github.ref_… #92
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7d37fc7
fix(create-new-release.yml): update client-payload to use github.ref_…
mauvehed 666ca42
ci(publish-docker-image.yml): add support for building and pushing a …
mauvehed e35e012
Update .github/workflows/publish-docker-image.yml
mauvehed 52038cb
chore(publish-docker-image.yml): refactor TAG variable assignment log…
mauvehed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -4,11 +4,14 @@ on: | |||||
push: | ||||||
paths: | ||||||
- 'Dockerfile' | ||||||
- '.github/workflows/publish-docker-image.yml' | ||||||
workflow_dispatch: | ||||||
# Triggered by a repository_dispatch event to allow external systems to initiate the workflow | ||||||
repository_dispatch: | ||||||
types: [publish-docker-image] | ||||||
workflow_dispatch: | ||||||
inputs: | ||||||
tag: | ||||||
description: 'Docker image tag' | ||||||
required: true | ||||||
default: 'nightly' | ||||||
|
||||||
jobs: | ||||||
build-and-publish: | ||||||
|
@@ -31,22 +34,24 @@ jobs: | |||||
username: ${{ github.repository_owner }} | ||||||
password: ${{ secrets.GITHUB_TOKEN }} | ||||||
|
||||||
- name: Build and push Docker image with version tag | ||||||
uses: docker/build-push-action@v5 | ||||||
with: | ||||||
context: . | ||||||
push: true | ||||||
tags: | | ||||||
ghcr.io/${{ github.repository_owner }}/yourip:${{ github.event.client_payload.tag }} | ||||||
ghcr.io/${{ github.repository_owner }}/yourip:latest | ||||||
|
||||||
- name: Build and push Docker image with nightly tag | ||||||
if: github.event.client_payload.tag == 'nightly' | ||||||
uses: docker/build-push-action@v3 | ||||||
with: | ||||||
context: . | ||||||
push: true | ||||||
tags: ghcr.io/${{ github.repository_owner }}/yourip:nightly | ||||||
- name: Build and push Docker image | ||||||
run: | | ||||||
TAG="${{ github.event.client_payload.tag || github.event.inputs.tag }}" | ||||||
if [ -z "${TAG}" ]; then | ||||||
mauvehed marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
echo "Tag is not defined" | ||||||
exit 1 | ||||||
fi | ||||||
|
||||||
if [ "${TAG}" = "nightly" ]; then | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion: Use double brackets for string comparison. Using double brackets
Suggested change
|
||||||
docker buildx build \ | ||||||
--tag ghcr.io/${{ github.repository_owner }}/yourip:nightly \ | ||||||
--push . | ||||||
else | ||||||
docker buildx build \ | ||||||
--tag ghcr.io/${{ github.repository_owner }}/yourip:${TAG} \ | ||||||
--tag ghcr.io/${{ github.repository_owner }}/yourip:latest \ | ||||||
--push . | ||||||
fi | ||||||
|
||||||
- name: Logout from GHCR | ||||||
run: docker logout ghcr.io |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Potential issue with tag extraction.
The expression
${{ github.event.client_payload.tag || github.event.inputs.tag }}
might not work as expected ifgithub.event.client_payload.tag
is an empty string. Consider using a more explicit check.