Only reset window position if it is out of bounds across multiple monitors and allow out of bounds option#69
Open
jmatth11 wants to merge 3 commits intomawie81:masterfrom
Open
Only reset window position if it is out of bounds across multiple monitors and allow out of bounds option#69jmatth11 wants to merge 3 commits intomawie81:masterfrom
jmatth11 wants to merge 3 commits intomawie81:masterfrom
Conversation
Add logic to only reset the window if the window is out of bounds of a view in a multi-monitor supported way.
Allow the user to configure the window state to be out of bounds. (all but one corner out of view)
jmatth11
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.) Add logic to only reset the window if the window is out of bounds of a view in a multi-monitor supported way.
Previously the window position would be reset if the window was in-between two monitors even though it was still visible. This change allows the window to not be reset even if it is between monitors as long as the window is in view.
2.) Allow an
outOfBoundsoption that is false by default. When set to true, the window position can be off screen but must maintain at least one corner in view.