Repository navigation
feat(examples): add Voice Live realtime plugin example #7436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
R-droid101
wants to merge
5
commits into
dev
Choose a base branch
from
09-23-feat_voicelive_realtime_plugin_example
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
48947cb
feat(examples): add Voice Live realtime plugin example
R-droid101 a100b8d
Merge branch 'dev' into 09-23-feat_voicelive_realtime_plugin_example
R-droid101 7acb458
fix(examples): bound relay writes and reject cleartext Voice Live end…
R-droid101 04d16c5
update docs
R-droid101 e07619e
Merge branch 'dev' into 09-23-feat_voicelive_realtime_plugin_example
R-droid101 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| .PHONY: build clean | ||
|
|
||
| build: | ||
| @echo "Building Voice Live Realtime plugin..." | ||
| @mkdir -p build | ||
| @go build -buildmode=plugin -o build/voicelive-realtime.so main.go | ||
| @echo "Plugin built successfully: build/voicelive-realtime.so" | ||
|
|
||
| clean: | ||
| @echo "Cleaning build directory..." | ||
| @rm -rf build | ||
| @echo "Clean complete" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,212 @@ | ||
| # Voice Live Realtime Plugin (PoC) | ||
|
|
||
| Serves **Azure AI Voice Live** realtime models — `gpt-realtime`, `phi4-mm-realtime` — over Bifrost's | ||
| existing `GET /v1/realtime` endpoint, using **only the HTTP transport plugin hooks**. No core change. | ||
|
|
||
| Bifrost has no Voice Live support today. This plugin adds it from the outside by hijacking the | ||
| client socket in `HTTPTransportPreHook`, completing the WebSocket upgrade itself, and relaying frames | ||
| to Voice Live in both directions. | ||
|
|
||
| > **Status: proof of concept.** It works, and the tests prove it end to end. It also bypasses | ||
| > governance, logging, telemetry and cost tracking — see [What this costs you](#what-this-costs-you). | ||
|
|
||
| ## Is this even possible? Yes — here is why | ||
|
|
||
| An HTTP→WebSocket upgrade is a 101 response plus a hijack of the underlying TCP socket. fasthttp | ||
| exposes that as `RequestCtx.Hijack`, and `HTTPTransportPreHook` runs inside the per-request goroutine | ||
| that owns the connection. So the only question is whether a plugin can reach the `*fasthttp.RequestCtx`. | ||
|
|
||
| It can, and not by accident. `TransportInterceptorMiddleware` builds the plugin's context like this: | ||
|
|
||
| ```go | ||
| bifrostCtx := schemas.NewBifrostContext(ctx, schemas.NoDeadline) // parent IS the *fasthttp.RequestCtx | ||
| bifrostCtx.SetValue(schemas.BifrostContextKeyModelCatalog, ...) // always stamped | ||
| pluginCtx := bifrostCtx.WithPluginScope(&pluginName) // what the hook receives | ||
| resp, err := plugin.HTTPTransportPreHook(pluginCtx, req) | ||
| ``` | ||
|
|
||
| and `WithPluginScope` (`core/schemas/context.go`) copies the parent across while leaving the scoped | ||
| value map empty: | ||
|
|
||
| ```go | ||
| scoped := &BifrostContext{ | ||
| parent: bc.parent, // ← the *fasthttp.RequestCtx | ||
| done: bc.done, | ||
| pluginScope: name, | ||
| valueDelegate: bc, | ||
| } | ||
| ``` | ||
|
|
||
| `GetParentCtxWithUserValues()` wraps `parent` in one `context.WithValue` layer per user value — and | ||
| the scoped context has none. So on the **plugin-scoped** context it returns the parent *unwrapped*: | ||
|
|
||
| ```go | ||
| rctx, ok := ctx.GetParentCtxWithUserValues().(*fasthttp.RequestCtx) // ok == true | ||
| ``` | ||
|
|
||
| (The **root** context does not work: it always has at least the model catalog set, so its parent | ||
| comes back wrapped in `*context.valueCtx`, which the stdlib gives you no way to unwrap.) | ||
|
|
||
| `TestRequestCtxIsReachableFromPluginScope` in `main_test.go` asserts exactly this. If it ever fails, | ||
| this plugin is dead and the fix is a core affordance — see [If this breaks](#if-this-breaks). | ||
|
|
||
| ### The flow | ||
|
|
||
| 1. `HTTPTransportPreHook` sees `GET /v1/realtime` with `Upgrade: websocket`. | ||
| 2. Model not in our list → `return nil, nil`, and Bifrost's own realtime handler serves it unchanged. | ||
| 3. Ours → capacity check, recover the `RequestCtx`, `upgrader.Upgrade(rctx, handler)`. | ||
| 4. Return `&schemas.HTTPResponse{StatusCode: 101}` so the transport stops and Bifrost's handler is | ||
| bypassed. `Headers` and `Body` are `nil` deliberately: `applyHTTPResponseToCtx` only *sets* what | ||
| it is given, so the handshake `Upgrade` already wrote survives untouched. | ||
| 5. In the hijacked goroutine: dial Voice Live and pump frames both ways until either side closes. | ||
|
|
||
| ### THE ONE RULE | ||
|
|
||
| **Never touch the `*fasthttp.RequestCtx` inside the hijack handler.** fasthttp recycles it as soon as | ||
| the request handler returns — which is *before* the hijack handler runs. Everything the connection | ||
| needs (model, upstream URL, headers, timeouts) is captured into locals **before** `Upgrade` is called. | ||
| The hijacked `net.Conn`, and the `*ws.Conn` wrapping it, outlive the `RequestCtx` and are safe. | ||
|
|
||
| This is the same hazard `core/schemas/context.go` guards against when it refuses to read values | ||
| through to a pooled `RequestCtx` parent — that refusal exists because reading a recycled ctx caused a | ||
| real SIGSEGV. | ||
|
|
||
| ## Why the obvious alternatives don't work | ||
|
|
||
| **Why not add Voice Live as a Bifrost provider from the plugin?** `wsrealtime.go` requires | ||
| `GetProviderByKey(provider)` to return a compiled-in provider implementing `schemas.RealtimeProvider` | ||
| (14 methods). The `.so` loader looks up a fixed symbol list; there is no provider-registration symbol. | ||
| A plugin cannot become a provider. | ||
|
|
||
| **Why not point Bifrost's existing Azure provider at Voice Live?** Because the URL is hardcoded | ||
| (`core/providers/azure/realtime.go`): | ||
|
|
||
| ```go | ||
| return fmt.Sprintf("%s/openai/v1/realtime?model=%s", endpoint, url.QueryEscape(model)) | ||
| ``` | ||
|
|
||
| Voice Live lives at `/voice-live/realtime` and requires an `api-version` query parameter. And | ||
| `RealtimeWebSocketURL(key, model, intent)` takes **no ctx**, so no plugin can influence it. The only | ||
| input is `key.AzureKeyConfig.Endpoint`, and no endpoint value produces the Voice Live URL — anything | ||
| you smuggle in lands *before* the hardcoded `?`, so `model` can never become its own query parameter. | ||
|
|
||
| **Why not buffer a turn over plain HTTP instead?** You can (short-circuit `PreLLMHook`, call Voice | ||
| Live, return the finished turn), but that gives up barge-in, incremental audio, and first-token | ||
| latency — i.e. everything that makes a realtime model worth using. The hijack keeps full duplex. | ||
|
|
||
| ## What this costs you | ||
|
|
||
| Short-circuiting at the transport layer means **Bifrost core never sees these connections**: | ||
|
|
||
| | Lost | Consequence | | ||
| |---|---| | ||
| | `PreLLMHook` / `PostLLMHook` | no governance, budgets, or rate limits per turn | | ||
| | Logging plugin | connections and turns do not appear in Bifrost logs | | ||
| | Telemetry / OTEL | no spans, no metrics | | ||
| | Cost tracking | no usage or spend attribution | | ||
| | `bfws.SessionManager` + connection pool | limits and pooling are the plugin's problem | | ||
|
|
||
| The plugin enforces its own `max_connections` for exactly that reason. Auth is **not** lost — | ||
| `HTTPTransportPreHook` runs *after* the transport's auth middlewares, so the caller is already | ||
| authenticated by the time the plugin claims the upgrade. | ||
|
|
||
| This is why the PoC is a PoC. The production shape is a `VoiceLiveProvider` in | ||
| `core/providers/voicelive/` implementing `schemas.RealtimeProvider`, which gets all of the above for | ||
| free. This plugin is how you find out whether Voice Live is worth that work — and it doubles as a | ||
| working reference for the wire protocol. | ||
|
|
||
| ## Building | ||
|
|
||
| ```bash | ||
| make build # -> build/voicelive-realtime.so | ||
| go test ./... # proves the hijack, the relay, and the fall-through | ||
| ``` | ||
|
|
||
| The tests run a real WebSocket client against a fake Voice Live server through a faithful replica of | ||
| `TransportInterceptorMiddleware`, and cover: claiming `gpt-realtime`, claiming `phi4-mm-realtime` | ||
| with a `azure/` prefix, text **and binary** frame relay, the upstream URL and `api-key` shape, and | ||
| unclaimed models falling through to Bifrost. | ||
|
|
||
| ## Configuration | ||
|
|
||
| ```json | ||
| { | ||
| "plugins": [ | ||
| { | ||
| "enabled": true, | ||
| "name": "voicelive-realtime", | ||
| "path": "/path/to/voicelive-realtime.so", | ||
| "config": { | ||
| "endpoint": "https://my-resource.services.ai.azure.com", | ||
| "api_key": "env.AZURE_VOICE_LIVE_KEY", | ||
| "api_version": "2025-10-01", | ||
| "models": ["gpt-realtime", "phi4-mm-realtime"], | ||
| "max_connections": 100, | ||
| "allowed_origins": ["https://app.example.com"], | ||
| "dial_timeout_seconds": 10, | ||
| "idle_timeout_seconds": 300 | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ``` | ||
|
|
||
| | Option | Type | Default | Description | | ||
| |---|---|---|---| | ||
| | `endpoint` | string | — | **Required.** Azure AI resource root. `http(s)` is rewritten to `ws(s)`. | | ||
| | `api_key` | SecretVar | — | **Required.** Literal, `env.NAME`, or `vault.path/to/secret`. Sent as the `api-key` header. | | ||
| | `api_version` | string | `2025-10-01` | Voice Live `api-version`. **Check this against your resource** — Azure revises it, and a stale value fails the handshake. | | ||
| | `models` | string[] | `["gpt-realtime", "phi4-mm-realtime"]` | Models this plugin claims. Everything else falls through to Bifrost. | | ||
| | `max_connections` | integer | `100` | Concurrent plugin-owned connections. Bifrost's session manager does not see hijacked sockets. | | ||
| | `allowed_origins` | string[] | same-host | Origin allowlist. `["*"]` allows any. Empty uses the library's safe default. | | ||
| | `dial_timeout_seconds` | integer | `10` | Upstream handshake timeout. | | ||
| | `idle_timeout_seconds` | integer | `300` | Read deadline on both sockets. | | ||
|
|
||
| ## Trying it | ||
|
|
||
| ```bash | ||
| # Claimed by the plugin -> proxied to Voice Live | ||
| websocat "ws://localhost:8080/v1/realtime?model=gpt-realtime" \ | ||
| -H "Authorization: Bearer $BIFROST_KEY" | ||
|
|
||
| # Also claimed | ||
| websocat "ws://localhost:8080/v1/realtime?model=phi4-mm-realtime" \ | ||
| -H "Authorization: Bearer $BIFROST_KEY" | ||
|
|
||
| # Not claimed -> Bifrost's native realtime handler, unchanged | ||
| websocat "ws://localhost:8080/v1/realtime?model=openai/gpt-4o-realtime-preview" \ | ||
| -H "Authorization: Bearer $BIFROST_KEY" | ||
| ``` | ||
|
|
||
| Session config, voices, avatars and noise-suppression settings are passed through verbatim in the | ||
| `session.update` event, so Azure-specific extensions work without the plugin knowing about them. | ||
|
|
||
| ## Known limitations | ||
|
|
||
| - **The path must already be routed.** Bifrost's router 404s unknown paths before any middleware runs | ||
| (`server.go`'s `Router.NotFound`), so a plugin can only intercept paths Bifrost already registers. | ||
| `/v1/realtime` is registered, which is why this works; a brand-new `/v1/voice-live` path would not. | ||
| - **No reconnect or upstream pooling.** Each client connection dials Voice Live fresh. | ||
| - **`GetParentCtxWithUserValues()` returning the raw `RequestCtx` is undocumented internal behaviour.** | ||
| It follows from `WithPluginScope` leaving the scoped value map empty. Nothing guarantees that stays | ||
| true. | ||
| - Go loads a `.so` once per path, so package-level state is shared by every plugin entry pointing at it. | ||
|
|
||
| ## If this breaks | ||
|
|
||
| If a future change stamps a value onto the plugin-scoped context before the hook runs, | ||
| `GetParentCtxWithUserValues()` starts returning a `*context.valueCtx` and the hijack becomes | ||
| impossible — silently, because the plugin would just fall through. `TestRequestCtxIsReachableFromPluginScope` | ||
| exists to catch that. The plugin also fails loudly with a `503` at runtime rather than passing the | ||
| request to a handler that cannot serve Voice Live. | ||
|
|
||
| The durable fix is a small core affordance, either of: | ||
|
|
||
| 1. **Expose the connection deliberately** — a documented accessor for the transport's `RequestCtx` | ||
| (or a narrow `Hijack(func(net.Conn))` on `BifrostContext`), so socket ownership is a supported | ||
| plugin capability rather than a lucky consequence of context plumbing. | ||
| 2. **Add a `RealtimeProvider` for Voice Live in core** — `core/providers/voicelive/`, which makes the | ||
| whole plugin unnecessary and restores governance, logging, telemetry and cost tracking. | ||
|
|
||
| Option 2 is the right production answer. Option 1 is what makes plugin-side realtime experiments like | ||
| this one legitimate rather than incidental. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| module github.com/maximhq/bifrost/examples/plugins/voicelive-realtime | ||
|
|
||
| go 1.27.0 | ||
|
|
||
| replace github.com/maximhq/bifrost/core => ../../../core | ||
|
|
||
| require ( | ||
| github.com/fasthttp/websocket v1.5.12 | ||
| github.com/maximhq/bifrost/core v0.0.0-00010101000000-000000000000 | ||
| github.com/valyala/fasthttp v1.74.0 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/bahlo/generic-list-go v0.2.0 // indirect | ||
| github.com/buger/jsonparser v1.2.0 // indirect | ||
| github.com/bytedance/gopkg v0.1.3 // indirect | ||
| github.com/bytedance/sonic v1.15.3-0.20260730064818-2a36d6da63e2 // indirect | ||
| github.com/bytedance/sonic/loader v0.5.2 // indirect | ||
| github.com/cloudwego/base64x v0.1.6 // indirect | ||
| github.com/google/uuid v1.6.0 // indirect | ||
| github.com/invopop/jsonschema v0.13.0 // indirect | ||
| github.com/klauspost/compress v1.20.0 // indirect | ||
| github.com/klauspost/cpuid/v2 v2.3.0 // indirect | ||
| github.com/mailru/easyjson v0.9.1 // indirect | ||
| github.com/mark3labs/mcp-go v0.43.2 // indirect | ||
| github.com/molecule-man/go-brrr v1.0.1 // indirect | ||
| github.com/savsgio/gotils v0.0.0-20250408102913-196191ec6287 // indirect | ||
| github.com/spf13/cast v1.10.0 // indirect | ||
| github.com/tidwall/gjson v1.18.0 // indirect | ||
| github.com/tidwall/match v1.1.1 // indirect | ||
| github.com/tidwall/pretty v1.2.1 // indirect | ||
| github.com/tidwall/sjson v1.2.5 // indirect | ||
| github.com/twitchyliquid64/golang-asm v0.15.1 // indirect | ||
| github.com/valyala/bytebufferpool v1.0.0 // indirect | ||
| github.com/wk8/go-ordered-map/v2 v2.1.8 // indirect | ||
| github.com/yosida95/uritemplate/v3 v3.0.2 // indirect | ||
| golang.org/x/arch v0.23.0 // indirect | ||
| golang.org/x/net v0.58.0 // indirect | ||
| golang.org/x/sys v0.47.0 // indirect | ||
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| ) | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.