Fix ry support for Safari #24991
Closed
Fix ry support for Safari #24991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:css 🎨
|
Moved to an issue, simpler #25021 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is not accurate https://developer.mozilla.org/en-US/docs/Web/CSS/ry#values
It references to this issue: https://bugs.webkit.org/show_bug.cgi?id=266090, which is labeled as a duplicate of https://bugs.webkit.org/show_bug.cgi?id=259646, and that got fixed. I can see it working on Safari 17.5, it's broken on Safari 17.3, so it got fixed in between. You can use the reproduction provided (https://codepen.io/sidewayss/pen/GRPgqvG) in one of those issues.
Not that my PR is broken, it still needs to:
rxNow, I have no bandwidth for this, so feel free to either push extra commits and transfer this as a new issue. Happy to report this in any cases.