Add mandatory annotations for OKD bundle #152
Conversation
|
Skipping CI for Draft Pull Request. |
Currently the release document created by CI uses github.ref_name in
place of the release version, but since we are not running this job on
tag creation anymore, this variable has the name of the branch instead
than the tag.
This change replaced {{github.ref_name}} with v{{inputs.version}}, which
contains the proper tag version.
Signed-off-by: Carlo Lobrano <[email protected]>
OKD community pipeline is verifying the presence of OCP annotation. Signed-off-by: Carlo Lobrano <[email protected]>
clobrano
force-pushed
the
add-mandatory-annotation-for-okd-0
branch
from
8538912
to
aaa780e
Compare
|
/test 4.16-openshift-e2e |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano, slintes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Deployment not completed (maybe network issue) |
|
/retest |
|
I made a mistake here. I was somehow using go > 1.20 locally and didn't notice, but since FAR has version 1.20, YQ needs to be <= 4.42.1, not 4.44.2 I will fix this in a next PR |
OKD community pipeline is verifying the presence of OCP annotation.
Moreover, I fixed a typo in the release template.
Why we need this PR
Changes made
Add OCP annotation to OKD bundle
Which issue(s) this PR fixes
Test plan