Reconcile if ExcludeFromRemediation label is removed #329
Conversation
|
Skipping CI for Draft Pull Request. |
clobrano
changed the title
controllers/shared.go
Outdated
| } | ||
|
|
||
| func labelsUpdateNeedsReconcile(oldLabels, newLabels map[string]string) bool { | ||
| // Check if the ExcludeFromRemediation label was removed |
There was a problem hiding this comment.
I'm wondering if it would make sense to reconcile a node with added label 🤔 It would at least give better visibility to what NHC is doing or not doing in the logs... WDYT?
There was a problem hiding this comment.
It makes sense to me (I just need to bring a logger to this function)
we could add a log when the label change is detected like:
- label added: "Label XYZ was added on Node ABC. Future remediations on this Node will be skipped
until the label is present" - label removed: "Label XYZ was removed on Node ABC."
I'm just not sure about the "Future remediation" part, but I don't want to give the idea that the
Node needs a remediation right now, and we are talking about "potential" future remediations.
I'd like to modify also the log
"Skipped remediation because node ABC is marked to exclude remediations"
into something like
"Remediation skipped on node ABC: node has remediation.medik8s.io/exclude-from-remediation label"
(or a more generic Exclude from remediation label, so that we don't need to maintain this log if we
ever need to change the label's name in the future)
There was a problem hiding this comment.
I mean returning true here in case the label was set. Reconcile we do the logging.
And +1 for improving the log message over there!
There was a problem hiding this comment.
I mean returning true here in case the label was set.
Just to make sure I get it right.
- you only mean commonLabels.ExcludeFromRemediation in that context and not other labels
- We will trigger the reconcile for "Excluded" nodes in order to have clearer logs/events and later on the reconcile method itself will identify the situation and stop.
clobrano
force-pushed
the
e1988-remediation-after-nmo-maintenance-0
branch
from
ec3f73e to
89303fb
Compare
clobrano
changed the title
In case ExcludeFromRemediation label is present, remediation is skipped. However if the Node is still unhealthy when the label is removed, it should be reconciled. Signed-off-by: Carlo Lobrano <[email protected]>
clobrano
force-pushed
the
e1988-remediation-after-nmo-maintenance-0
branch
from
89303fb to
00edf09
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano, slintes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
ping tide |
|
/lgtm cancel |
|
/lgtm |
|
/lgtm cancel |
|
/lgtm |
|
/cherry-pick release-0.8 |
|
@clobrano: new pull request created: #331 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Why we need this PR
In case ExcludeFromRemediation label is present, remediation is skipped,
however if the Node is still unhealthy when the label is removed it
should be reconciled.
Changes made
Watch for changes in the Node's labels. If ExcludeFromRemediation is removed reconcile the Node.
Which issue(s) this PR fixes
https://issues.redhat.com/browse/ECOPROJECT-1988
Test plan