MM2-2094 fix—Refactored register page to extract RegisterSchema and PasswordValidator modules for better code organization.
#263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alidator` modules for better code organization. - Enhanced password validation with specific requirements and visual hints. - Added `clsx` dependency for conditional class management.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kilias07
changed the title
RegisterSchema and PasswordValidator modules for better code organization. - Enhanced password validation with specific requirements and visual hints. - Added clsx dependency for conditional class management.RegisterSchema and PasswordValidator modules for better code organization.
|
|
||
| return ( | ||
| <Container className="p-2 flex flex-col gap-y-1"> | ||
| <p |
Collaborator
There was a problem hiding this comment.
This could be extracted to
const rules = [
{ key: 'chars8', label: 'At least 8 characters' },
...rest of keys
]
and later mapped through to not duplicate paragraphs, icons, styles, etc
from the other side it's small and easy to maintain, so it depends on you
| newPasswordError['8chars'] ? 'text-red-700' : 'text-green-700' | ||
| )} | ||
| > | ||
| <CheckCircle /> At least 8 characters |
Collaborator
There was a problem hiding this comment.
Please add translations
| password: z.string().min(8, { message: "Password should have at least 8 characters" }), | ||
| confirmPassword: z.string() | ||
| }) .refine((data) => data.password === data.confirmPassword, { | ||
| message: "passwords don't match", |
Collaborator
There was a problem hiding this comment.
First letter is missing upper case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.