-
Notifications
You must be signed in to change notification settings - Fork 71
MM2-2094 fix—Refactored register page to extract RegisterSchema and PasswordValidator modules for better code organization.
#263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kilias07
wants to merge
1
commit into
development
Choose a base branch
from
MM2-2094
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| 'use client'; | ||
|
|
||
| import { useEffect, useState } from 'react'; | ||
|
|
||
| import { CheckCircle } from '@medusajs/icons'; | ||
| import { Container } from '@medusajs/ui'; | ||
| import { clsx } from 'clsx'; | ||
|
|
||
| function validatePassword(password: string) { | ||
| const errors = { | ||
| tooShort: password.length < 8, | ||
| noLower: !/[a-z]/.test(password), | ||
| noUpper: !/[A-Z]/.test(password), | ||
| noDigitOrSymbol: !/[0-9!@#$%^&*(),.?":{}|<>_\-+=\[\]\\\/~`]/.test(password) | ||
| }; | ||
|
|
||
| return { | ||
| isValid: !Object.values(errors).some(Boolean), | ||
| errors | ||
| }; | ||
| } | ||
|
|
||
| export const PasswordValidator = ({ | ||
| password, | ||
| setError | ||
| }: { | ||
| password: string; | ||
| setError: (error: any) => void; | ||
| }) => { | ||
| const [newPasswordError, setNewPasswordError] = useState({ | ||
| isValid: false, | ||
| lower: false, | ||
| upper: false, | ||
| '8chars': false, | ||
| symbolOrDigit: false | ||
| }); | ||
|
|
||
| useEffect(() => { | ||
| const validation = validatePassword(password); | ||
|
|
||
| setError({ | ||
| isValid: validation.isValid, | ||
| lower: validation.errors.noLower, | ||
| upper: validation.errors.noUpper, | ||
| '8chars': validation.errors.tooShort, | ||
| symbolOrDigit: validation.errors.noDigitOrSymbol | ||
| }); | ||
| setNewPasswordError({ | ||
| isValid: validation.isValid, | ||
| lower: validation.errors.noLower, | ||
| upper: validation.errors.noUpper, | ||
| '8chars': validation.errors.tooShort, | ||
| symbolOrDigit: validation.errors.noDigitOrSymbol | ||
| }); | ||
| }, [password]); | ||
|
|
||
|
|
||
| return ( | ||
| <Container className="p-2 flex flex-col gap-y-1"> | ||
| <p | ||
| className={clsx( | ||
| 'text-xs flex items-center gap-2', | ||
| newPasswordError['8chars'] ? 'text-red-700' : 'text-green-700' | ||
| )} | ||
| > | ||
| <CheckCircle /> At least 8 characters | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add translations |
||
| </p> | ||
| <p | ||
| className={clsx( | ||
| 'text-xs flex items-center gap-2', | ||
| newPasswordError['lower'] ? 'text-red-700' : 'text-green-700' | ||
| )} | ||
| > | ||
| <CheckCircle /> One lowercase letter | ||
| </p> | ||
| <p | ||
| className={clsx( | ||
| 'text-xs flex items-center gap-2', | ||
| newPasswordError['upper'] ? 'text-red-700' : 'text-green-700' | ||
| )} | ||
| > | ||
| <CheckCircle /> One uppercase letter | ||
| </p> | ||
| <p | ||
| className={clsx( | ||
| 'text-xs flex items-center gap-2', | ||
| newPasswordError['symbolOrDigit'] ? 'text-red-700' : 'text-green-700' | ||
| )} | ||
| > | ||
| <CheckCircle /> One number or symbol | ||
| </p> | ||
| </Container> | ||
| ); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import * as z from 'zod'; | ||
|
|
||
| export const RegisterSchema = z.object({ | ||
| name: z.string().min(2, { message: "Name should be a string" }), | ||
| email: z.string().email({ message: "Invalid email" }), | ||
| password: z.string().min(8, { message: "Password should have at least 8 characters" }), | ||
| confirmPassword: z.string() | ||
| }) .refine((data) => data.password === data.confirmPassword, { | ||
| message: "passwords don't match", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. First letter is missing upper case |
||
| path: ['confirmPassword'], | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be extracted to
and later mapped through to not duplicate paragraphs, icons, styles, etc
from the other side it's small and easy to maintain, so it depends on you