Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
"@tanstack/react-table": "8.20.5",
"@tanstack/react-virtual": "^3.8.3",
"@uiw/react-json-view": "^2.0.0-alpha.17",
"clsx": "^2.1.1",
"cmdk": "^0.2.0",
"date-fns": "^3.6.0",
"i18next": "23.7.11",
Expand Down
94 changes: 94 additions & 0 deletions src/routes/register/password-hints.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
'use client';

import { useEffect, useState } from 'react';

import { CheckCircle } from '@medusajs/icons';
import { Container } from '@medusajs/ui';
import { clsx } from 'clsx';

function validatePassword(password: string) {
const errors = {
tooShort: password.length < 8,
noLower: !/[a-z]/.test(password),
noUpper: !/[A-Z]/.test(password),
noDigitOrSymbol: !/[0-9!@#$%^&*(),.?":{}|<>_\-+=\[\]\\\/~`]/.test(password)
};

return {
isValid: !Object.values(errors).some(Boolean),
errors
};
}

export const PasswordValidator = ({
password,
setError
}: {
password: string;
setError: (error: any) => void;
}) => {
const [newPasswordError, setNewPasswordError] = useState({
isValid: false,
lower: false,
upper: false,
'8chars': false,
symbolOrDigit: false
});

useEffect(() => {
const validation = validatePassword(password);

setError({
isValid: validation.isValid,
lower: validation.errors.noLower,
upper: validation.errors.noUpper,
'8chars': validation.errors.tooShort,
symbolOrDigit: validation.errors.noDigitOrSymbol
});
setNewPasswordError({
isValid: validation.isValid,
lower: validation.errors.noLower,
upper: validation.errors.noUpper,
'8chars': validation.errors.tooShort,
symbolOrDigit: validation.errors.noDigitOrSymbol
});
}, [password]);


return (
<Container className="p-2 flex flex-col gap-y-1">
<p
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be extracted to

const rules = [
    { key: 'chars8', label: 'At least 8 characters' },
    ...rest of keys
]

and later mapped through to not duplicate paragraphs, icons, styles, etc

from the other side it's small and easy to maintain, so it depends on you

className={clsx(
'text-xs flex items-center gap-2',
newPasswordError['8chars'] ? 'text-red-700' : 'text-green-700'
)}
>
<CheckCircle /> At least 8 characters
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add translations

</p>
<p
className={clsx(
'text-xs flex items-center gap-2',
newPasswordError['lower'] ? 'text-red-700' : 'text-green-700'
)}
>
<CheckCircle /> One lowercase letter
</p>
<p
className={clsx(
'text-xs flex items-center gap-2',
newPasswordError['upper'] ? 'text-red-700' : 'text-green-700'
)}
>
<CheckCircle /> One uppercase letter
</p>
<p
className={clsx(
'text-xs flex items-center gap-2',
newPasswordError['symbolOrDigit'] ? 'text-red-700' : 'text-green-700'
)}
>
<CheckCircle /> One number or symbol
</p>
</Container>
);
};
11 changes: 11 additions & 0 deletions src/routes/register/register-schema.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import * as z from 'zod';

export const RegisterSchema = z.object({
name: z.string().min(2, { message: "Name should be a string" }),
email: z.string().email({ message: "Invalid email" }),
password: z.string().min(8, { message: "Password should have at least 8 characters" }),
confirmPassword: z.string()
}) .refine((data) => data.password === data.confirmPassword, {
message: "passwords don't match",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First letter is missing upper case

path: ['confirmPassword'],
});
Loading