Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with wget not working during docker build #5755

Closed

Conversation

kairi003
Copy link
Contributor

@kairi003 kairi003 commented Aug 23, 2024

📑 Summary

wget was failed on Alpine as reported in Yelp/dumb-init#73 during docker build.
This means that piped pnpm installs also fail.

Resolves #5754

📏 Design Decisions

📋 Tasks

This is not a change to the application code, but a modification to the development environment setup.
There seems to be no documentation or testing to begin with.

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Aug 23, 2024

⚠️ No Changeset found

Latest commit: d7965f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Aug 23, 2024
Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit d7965f7
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66c8ed36b0197c000892f0c5
😎 Deploy Preview https://deploy-preview-5755--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.21%. Comparing base (a10f469) to head (d7965f7).
Report is 44 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5755   +/-   ##
=======================================
  Coverage     5.21%   5.21%           
=======================================
  Files          323     322    -1     
  Lines        46094   46083   -11     
  Branches       536     561   +25     
=======================================
  Hits          2402    2402           
+ Misses       43692   43681   -11     
Flag Coverage Δ
unit 5.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link

argos-ci bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected 2 failures Aug 23, 2024, 8:24 PM

@kairi003 kairi003 deleted the bug/5754_fix_wget_on_dockerfile branch November 10, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wget installation fails on Alpine during Dockerfile build
1 participant