Skip to content

Conversation

vidplace7
Copy link
Member

What does this PR do?

Add event_mode_enabled and event_mode_title to LocalConfig proto.

This should facilitate the firmware conveying "I am in event_mode, burningmesh2025" to clients, which can choose to behave differently (example, load custom Burning Man KML in App when using the event firmware)

Checklist before merging

  • All top level messages commented
  • All enum members have unique descriptions

@caveman99 caveman99 requested a review from Copilot July 21, 2025 10:32
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds event mode configuration options to the LocalConfig proto message to allow firmware to communicate event-specific information to clients. This enables clients to modify their behavior based on the event context, such as loading custom KML files for specific events like Burning Man.

  • Added event_mode_enabled boolean flag to indicate firmware support for event mode
  • Added event_mode_title string field to specify the event name/identifier
  • Set size constraint for the event title field to 33 characters maximum

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
meshtastic/localonly.proto Adds two new fields to LocalConfig message for event mode configuration
meshtastic/localonly.options Defines maximum size constraint for the event_mode_title field

Comment on lines +73 to +75
* Title for event mode firmware
* Ex: "burningmesh2025"
* Set at compile time, consumed by clients to modify UI behavior
Copy link
Preview

Copilot AI Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment should clarify the expected format or constraints for the event_mode_title. Consider documenting whether it should be alphanumeric only, lowercase, or follow specific naming conventions since it affects client UI behavior.

Suggested change
* Title for event mode firmware
* Ex: "burningmesh2025"
* Set at compile time, consumed by clients to modify UI behavior
* Title for event mode firmware.
* Expected format: alphanumeric, lowercase, no spaces, maximum 32 characters.
* Example: "burningmesh2025"
* This value is set at compile time and is consumed by clients to modify UI behavior.

Copilot uses AI. Check for mistakes.

@vidplace7
Copy link
Member Author

Superseded by #739

@vidplace7 vidplace7 closed this Jul 25, 2025
@vidplace7 vidplace7 deleted the localonly-event_mode branch July 25, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants