Skip to content

Add event_mode options to LocalConfig #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add event_mode options to LocalConfig #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions meshtastic/localonly.options
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*LocalConfig.event_mode_title max_size:33
12 changes: 12 additions & 0 deletions meshtastic/localonly.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,18 @@ message LocalConfig {
* The part of the config that is specific to Security settings
*/
Config.SecurityConfig security = 9;

/*
* Set when the firmware has been compiled with event mode support
*/
bool event_mode_enabled = 10;

/*
* Title for event mode firmware
* Ex: "burningmesh2025"
* Set at compile time, consumed by clients to modify UI behavior
Comment on lines +73 to +75
Copy link
Preview

Copilot AI Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment should clarify the expected format or constraints for the event_mode_title. Consider documenting whether it should be alphanumeric only, lowercase, or follow specific naming conventions since it affects client UI behavior.

Suggested change
* Title for event mode firmware
* Ex: "burningmesh2025"
* Set at compile time, consumed by clients to modify UI behavior
* Title for event mode firmware.
* Expected format: alphanumeric, lowercase, no spaces, maximum 32 characters.
* Example: "burningmesh2025"
* This value is set at compile time and is consumed by clients to modify UI behavior.

Copilot uses AI. Check for mistakes.

*/
string event_mode_title = 11;
}

message LocalModuleConfig {
Expand Down