-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuring auditing with timescaledb. #217
Conversation
@@ -18,7 +18,7 @@ | |||
tags: ipam-db | |||
- name: metal-roles/control-plane/roles/masterdata-db | |||
tags: masterdata-db | |||
- name: metal-roles/control-plane/roles/auditing-meili | |||
- name: metal-roles/control-plane/roles/auditing-timescaledb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not possible to toggle this role depending on a value switch like an environment variable, right?
If not: I think it would make sense for the mini-lab to include both backends for the mini-lab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's now possible to use both backends. By default it's TimescaleDB, but backends can be toggled using the variables metal_auditing_timescaledb_enabled
and metal_auditing_meili_enabled
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really vote for only one backend, we should simplify not complicate things. If we are not convinced with the existing solution we should get rid of it completely. Same applies for the extra code in the metal-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After we gained confidence we can decide if we want to throw out one. Having both options during transition phase is I think helpful. And there will also be a Splunk backend I hope soon, which is not searchable, so in general it's good to have everything prepared for another backend.
Description
References: