Conversation
|
This clippy error is really weird
|
|
Yeah, that's strange. Interestingly, this lint is not triggered by #75. |
|
Rust 1.58.1 has been released, I've restarted CI and now it passes. |
| producer: &'a Producer<T>, | ||
| } | ||
|
|
||
| unsafe impl<T: Send> Send for WriteChunkUninit<'_, T> {} |
There was a problem hiding this comment.
What about adding a comment regarding safety?
Maybe something like this:
// WriteChunkUninit only exists while a unique reference to the Producer is held.
// It is therefore safe to move it to another thread.
mgeier
left a comment
There was a problem hiding this comment.
I've added comments as suggestions, what do you think about them?
Co-authored-by: Matthias Geier <Matthias.Geier@gmail.com>
#4