Skip to content

Implement Send for chunk types #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgeier merged 2 commits into from
Mar 3, 2022
Merged

Implement Send for chunk types #78

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2064a09
Implement `Send` for chunk types
RamType0 Jan 17, 2022
d7c6bdb
Add comments about `Send` safety for chunk types
RamType0 Feb 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/chunks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,10 @@ pub struct WriteChunkUninit<'a, T> {
producer: &'a Producer<T>,
}

// WriteChunkUninit only exists while a unique reference to the Producer is held.
// It is therefore safe to move it to another thread.
unsafe impl<T: Send> Send for WriteChunkUninit<'_, T> {}
Copy link
Owner

@mgeier mgeier Jan 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding a comment regarding safety?

Maybe something like this:

// WriteChunkUninit only exists while a unique reference to the Producer is held.
// It is therefore safe to move it to another thread.


impl<T> WriteChunkUninit<'_, T> {
/// Returns two slices for writing to the requested slots.
///
Expand Down Expand Up @@ -614,6 +618,10 @@ pub struct ReadChunk<'a, T> {
consumer: &'a mut Consumer<T>,
}

// ReadChunk only exists while a unique reference to the Consumer is held.
// It is therefore safe to move it to another thread.
unsafe impl<T: Send> Send for ReadChunk<'_, T> {}

impl<T> ReadChunk<'_, T> {
/// Returns two slices for reading from the requested slots.
///
Expand Down