refactor: perform dimensional analysis and numerical evaluation in same pass #1557
Annotations
10 errors, 1 warning, and 1 notice
|
Run Playwright tests:
tests/test_database.spec.mjs#L186
1) [chromium] › test_database.spec.mjs:176:1 › Test database consistency ─────────────────────────
TimeoutError: locator.waitFor: Timeout 5000ms exceeded.
Call log:
- waiting for locator('h3').locator('text=Retrieving Sheet') to be detached
184 | await page.setViewportSize({ width: width, height: height });
185 |
> 186 | await page.locator('h3 >> text=Retrieving Sheet').waitFor({state: 'detached', timeout: 5000});
| ^
187 | await page.locator('text=Accept').click();
188 | await page.waitForSelector('.status-footer', { state: 'detached', timeout: pyodideLoadTimeout });
189 | await page.keyboard.press('Escape'); // unselect all cells
at /home/runner/work/EngineeringPaper.xyz/EngineeringPaper.xyz/tests/test_database.spec.mjs:186:53
|
|
Run Playwright tests:
tests/test_database.spec.mjs#L186
1) [chromium] › test_database.spec.mjs:176:1 › Test database consistency ─────────────────────────
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
TimeoutError: locator.waitFor: Timeout 5000ms exceeded.
Call log:
- waiting for locator('h3').locator('text=Retrieving Sheet') to be detached
184 | await page.setViewportSize({ width: width, height: height });
185 |
> 186 | await page.locator('h3 >> text=Retrieving Sheet').waitFor({state: 'detached', timeout: 5000});
| ^
187 | await page.locator('text=Accept').click();
188 | await page.waitForSelector('.status-footer', { state: 'detached', timeout: pyodideLoadTimeout });
189 | await page.keyboard.press('Escape'); // unselect all cells
at /home/runner/work/EngineeringPaper.xyz/EngineeringPaper.xyz/tests/test_database.spec.mjs:186:53
|
|
Run Playwright tests:
tests/test_database.spec.mjs#L194
1) [chromium] › test_database.spec.mjs:176:1 › Test database consistency ─────────────────────────
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(received).toEqual(expected) // deep equality
Expected: 0
Received: 5139
192 | await page.screenshot({ path: `${screenshotDir}/${browserName}_screenshot_reference_check.png`, fullPage: true });
193 |
> 194 | expect(compareImages(`${browserName}_reference.png`, `${browserName}_screenshot_reference_check.png`)).toEqual(0);
| ^
195 | });
at /home/runner/work/EngineeringPaper.xyz/EngineeringPaper.xyz/tests/test_database.spec.mjs:194:106
|
|
Run Playwright tests:
tests/test_number_format.spec.mjs#L584
2) [chromium] › test_number_format.spec.mjs:551:1 › Test intermediate results rendering edge cases
Error: expect(received).toBe(expected) // Object.is equality
Expected: "\\left( 0\\left\\lbrack m\\right\\rbrack \\right)\\cdot \\left(\\text{Dimension Error}\\right) = "
Received: "\\left( 0\\left\\lbrack m\\right\\rbrack \\right)\\cdot \\left(\\text{Dimension Error: Only equivalent dimensions can be added or subtracted.}\\right) = "
582 |
583 | content = await page.textContent('#result-value-4');
> 584 | expect(content).toBe(String.raw`\left( 0\left\lbrack m\right\rbrack \right)\cdot \left(\text{Dimension Error}\right) = `);
| ^
585 |
586 | // change default units and make sure numbers in intermediate results update to match
587 | await page.getByRole('button', { name: 'Sheet Settings' }).click();
at /home/runner/work/EngineeringPaper.xyz/EngineeringPaper.xyz/tests/test_number_format.spec.mjs:584:19
|
|
Run Playwright tests:
tests/test_number_format.spec.mjs#L584
2) [chromium] › test_number_format.spec.mjs:551:1 › Test intermediate results rendering edge cases
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(received).toBe(expected) // Object.is equality
Expected: "\\left( 0\\left\\lbrack m\\right\\rbrack \\right)\\cdot \\left(\\text{Dimension Error}\\right) = "
Received: "\\left( 0\\left\\lbrack m\\right\\rbrack \\right)\\cdot \\left(\\text{Dimension Error: Only equivalent dimensions can be added or subtracted.}\\right) = "
582 |
583 | content = await page.textContent('#result-value-4');
> 584 | expect(content).toBe(String.raw`\left( 0\left\lbrack m\right\rbrack \right)\cdot \left(\text{Dimension Error}\right) = `);
| ^
585 |
586 | // change default units and make sure numbers in intermediate results update to match
587 | await page.getByRole('button', { name: 'Sheet Settings' }).click();
at /home/runner/work/EngineeringPaper.xyz/EngineeringPaper.xyz/tests/test_number_format.spec.mjs:584:19
|
|
Run Playwright tests:
tests/test_number_format.spec.mjs#L584
2) [chromium] › test_number_format.spec.mjs:551:1 › Test intermediate results rendering edge cases
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(received).toBe(expected) // Object.is equality
Expected: "\\left( 0\\left\\lbrack m\\right\\rbrack \\right)\\cdot \\left(\\text{Dimension Error}\\right) = "
Received: "\\left( 0\\left\\lbrack m\\right\\rbrack \\right)\\cdot \\left(\\text{Dimension Error: Only equivalent dimensions can be added or subtracted.}\\right) = "
582 |
583 | content = await page.textContent('#result-value-4');
> 584 | expect(content).toBe(String.raw`\left( 0\left\lbrack m\right\rbrack \right)\cdot \left(\text{Dimension Error}\right) = `);
| ^
585 |
586 | // change default units and make sure numbers in intermediate results update to match
587 | await page.getByRole('button', { name: 'Sheet Settings' }).click();
at /home/runner/work/EngineeringPaper.xyz/EngineeringPaper.xyz/tests/test_number_format.spec.mjs:584:19
|
|
Run Playwright tests:
tests/test_database.spec.mjs#L194
3) [firefox] › test_database.spec.mjs:176:1 › Test database consistency ──────────────────────────
Error: expect(received).toEqual(expected) // deep equality
Expected: 0
Received: 5830
192 | await page.screenshot({ path: `${screenshotDir}/${browserName}_screenshot_reference_check.png`, fullPage: true });
193 |
> 194 | expect(compareImages(`${browserName}_reference.png`, `${browserName}_screenshot_reference_check.png`)).toEqual(0);
| ^
195 | });
at /home/runner/work/EngineeringPaper.xyz/EngineeringPaper.xyz/tests/test_database.spec.mjs:194:106
|
|
Run Playwright tests:
tests/test_database.spec.mjs#L194
3) [firefox] › test_database.spec.mjs:176:1 › Test database consistency ──────────────────────────
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(received).toEqual(expected) // deep equality
Expected: 0
Received: 5830
192 | await page.screenshot({ path: `${screenshotDir}/${browserName}_screenshot_reference_check.png`, fullPage: true });
193 |
> 194 | expect(compareImages(`${browserName}_reference.png`, `${browserName}_screenshot_reference_check.png`)).toEqual(0);
| ^
195 | });
at /home/runner/work/EngineeringPaper.xyz/EngineeringPaper.xyz/tests/test_database.spec.mjs:194:106
|
|
Run Playwright tests:
tests/test_database.spec.mjs#L194
3) [firefox] › test_database.spec.mjs:176:1 › Test database consistency ──────────────────────────
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(received).toEqual(expected) // deep equality
Expected: 0
Received: 5830
192 | await page.screenshot({ path: `${screenshotDir}/${browserName}_screenshot_reference_check.png`, fullPage: true });
193 |
> 194 | expect(compareImages(`${browserName}_reference.png`, `${browserName}_screenshot_reference_check.png`)).toEqual(0);
| ^
195 | });
at /home/runner/work/EngineeringPaper.xyz/EngineeringPaper.xyz/tests/test_database.spec.mjs:194:106
|
|
Run Playwright tests:
tests/test_number_format.spec.mjs#L584
4) [firefox] › test_number_format.spec.mjs:551:1 › Test intermediate results rendering edge cases
Error: expect(received).toBe(expected) // Object.is equality
Expected: "\\left( 0\\left\\lbrack m\\right\\rbrack \\right)\\cdot \\left(\\text{Dimension Error}\\right) = "
Received: "\\left( 0\\left\\lbrack m\\right\\rbrack \\right)\\cdot \\left(\\text{Dimension Error: Only equivalent dimensions can be added or subtracted.}\\right) = "
582 |
583 | content = await page.textContent('#result-value-4');
> 584 | expect(content).toBe(String.raw`\left( 0\left\lbrack m\right\rbrack \right)\cdot \left(\text{Dimension Error}\right) = `);
| ^
585 |
586 | // change default units and make sure numbers in intermediate results update to match
587 | await page.getByRole('button', { name: 'Sheet Settings' }).click();
at /home/runner/work/EngineeringPaper.xyz/EngineeringPaper.xyz/tests/test_number_format.spec.mjs:584:19
|
|
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "screenshots", "test-results".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
|
Run Playwright tests
8 failed
[chromium] › test_database.spec.mjs:176:1 › Test database consistency ──────────────────────────
[chromium] › test_number_format.spec.mjs:551:1 › Test intermediate results rendering edge cases
[firefox] › test_database.spec.mjs:176:1 › Test database consistency ───────────────────────────
[firefox] › test_number_format.spec.mjs:551:1 › Test intermediate results rendering edge cases ─
[firefox] › test_plotting.spec.mjs:354:1 › Test copy plot data ─────────────────────────────────
[firefox] › test_plotting.spec.mjs:639:1 › Test visual comparison of function plot with identical scatter line plot
[firefox] › test_plotting.spec.mjs:764:1 › Test visual comparison of function plot with identical parametric plot
[firefox] › test_symbolic_expression_error_handling.spec.mjs:5:1 › Test handling of symbolic expression error
8 flaky
[chromium] › test_matrix_inverse.spec.mjs:114:1 › Inverse of symbolic matrix ───────────────────
[chromium] › test_plotting.spec.mjs:153:1 › Test plot number of points ─────────────────────────
[chromium] › test_system_solve.spec.mjs:193:1 › Test solving system of 3 equations ─────────────
[firefox] › test_checkpoints.spec.mjs:15:1 › Test autosave checkpoints ─────────────────────────
[firefox] › test_custom_base_units.spec.mjs:159:1 › Test custom base units for scatter plot ────
[firefox] › test_file_save_open.spec.mjs:138:1 › Test opening file with results and syntax error
[firefox] › test_matrix_determinant.spec.mjs:16:1 › Determinant of matrix literal using keyboard entry
[firefox] › test_matrix_inverse.spec.mjs:98:1 › Inverse for nonsquare matrix ───────────────────
9 skipped
753 passed (27.3m)
|
Loading