Fix parameter naming inconsistencies in WSLAContainerLauncher

[Copilot]

Summary of the Pull Request

Addresses naming inconsistencies in WSLAContainerLauncher.h and WSLAContainerLauncher.cpp. Constructor parameters now consistently use PascalCase throughout the file.

PR Checklist

• Closes: Implement container network mode #13886 (stacked PR addressing review feedback)
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated if needed and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated if needed
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Renamed parameters in both header and implementation files to maintain PascalCase consistency:

1. WSLAContainerLauncher Constructor

• WSLAContainerLauncher.h: Parameter declaration and default value
• WSLAContainerLauncher.cpp: Parameter declaration and constructor initializer list

Before:

WSLAContainerLauncher(
    const std::string& Image,
    const std::string& Name,
    WSLA_CONTAINER_NETWORK_TYPE containerNetworkType = ...,
    ProcessFlags Flags = ...);

After:

WSLAContainerLauncher(
    const std::string& Image,
    const std::string& Name,
    WSLA_CONTAINER_NETWORK_TYPE ContainerNetworkType = ...,
    ProcessFlags Flags = ...);

2. RunningWSLAContainer Constructor

• WSLAContainerLauncher.h: Parameter declaration
• WSLAContainerLauncher.cpp: Parameter declaration and constructor initializer list

Before:

RunningWSLAContainer(wil::com_ptr<IWSLAContainer>&& Container, std::vector<WSLA_PROCESS_FD>&& fds);

After:

RunningWSLAContainer(wil::com_ptr<IWSLAContainer>&& Container, std::vector<WSLA_PROCESS_FD>&& Fds);

Member variables (m_fds, m_containerNetworkType) retain camelCase per project convention.

Validation Steps Performed

• Verified clang-format compliance
• Confirmed all parameter names now use PascalCase consistently
• Code review passed with no issues

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[benhillis]

@copilot - are there other naming inconsistencies in this file?

[Copilot]

@copilot - are there other naming inconsistencies in this file?

Yes, there's one more: the fds parameter in RunningWSLAContainer constructor (line 25 in the header) uses camelCase instead of PascalCase. It should be Fds to match the convention used for other parameters like Container, HostPath, ContainerPath, WindowsPort, etc.

[benhillis]

@copilot - are there other naming inconsistencies in this file?

Yes, there's one more: the fds parameter in RunningWSLAContainer constructor (line 25 in the header) uses camelCase instead of PascalCase. It should be Fds to match the convention used for other parameters like Container, HostPath, ContainerPath, WindowsPort, etc.

@copilot - ok fix that one too.

[Copilot]

@copilot - are there other naming inconsistencies in this file?

Yes, there's one more: the fds parameter in RunningWSLAContainer constructor (line 25 in the header) uses camelCase inste...

Done in commit 2256d08. The fds parameter in RunningWSLAContainer constructor is now Fds to match the PascalCase convention.