Skip to content

Fix parameter naming inconsistencies in WSLAContainerLauncher #13911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptrivedi merged 3 commits into from
Dec 15, 2025
Merged

Fix parameter naming inconsistencies in WSLAContainerLauncher #13911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
605bb1f
Initial plan
Copilot Dec 15, 2025
245b5ce
Rename containerNetworkType parameter to ContainerNetworkType for nam…
Copilot Dec 15, 2025
2256d08
Rename fds parameter to Fds in RunningWSLAContainer constructor
Copilot Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/windows/common/WSLAContainerLauncher.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ using wsl::windows::common::ClientRunningWSLAProcess;
using wsl::windows::common::RunningWSLAContainer;
using wsl::windows::common::WSLAContainerLauncher;

RunningWSLAContainer::RunningWSLAContainer(wil::com_ptr<IWSLAContainer>&& Container, std::vector<WSLA_PROCESS_FD>&& fds) :
m_container(std::move(Container)), m_fds(std::move(fds))
RunningWSLAContainer::RunningWSLAContainer(wil::com_ptr<IWSLAContainer>&& Container, std::vector<WSLA_PROCESS_FD>&& Fds) :
m_container(std::move(Container)), m_fds(std::move(Fds))
{
}

Expand Down Expand Up @@ -48,9 +48,9 @@ WSLAContainerLauncher::WSLAContainerLauncher(
const std::string& EntryPoint,
const std::vector<std::string>& Arguments,
const std::vector<std::string>& Environment,
WSLA_CONTAINER_NETWORK_TYPE containerNetworkType,
WSLA_CONTAINER_NETWORK_TYPE ContainerNetworkType,
ProcessFlags Flags) :
WSLAProcessLauncher(EntryPoint, Arguments, Environment, Flags), m_image(Image), m_name(Name), m_containerNetworkType(containerNetworkType)
WSLAProcessLauncher(EntryPoint, Arguments, Environment, Flags), m_image(Image), m_name(Name), m_containerNetworkType(ContainerNetworkType)
{
}

Expand Down
4 changes: 2 additions & 2 deletions src/windows/common/WSLAContainerLauncher.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class RunningWSLAContainer
public:
NON_COPYABLE(RunningWSLAContainer);
DEFAULT_MOVABLE(RunningWSLAContainer);
RunningWSLAContainer(wil::com_ptr<IWSLAContainer>&& Container, std::vector<WSLA_PROCESS_FD>&& fds);
RunningWSLAContainer(wil::com_ptr<IWSLAContainer>&& Container, std::vector<WSLA_PROCESS_FD>&& Fds);
IWSLAContainer& Get();

WSLA_CONTAINER_STATE State();
Expand All @@ -45,7 +45,7 @@ class WSLAContainerLauncher : private WSLAProcessLauncher
const std::string& EntryPoint = "",
const std::vector<std::string>& Arguments = {},
const std::vector<std::string>& Environment = {},
WSLA_CONTAINER_NETWORK_TYPE containerNetworkType = WSLA_CONTAINER_NETWORK_TYPE::WSLA_CONTAINER_NETWORK_HOST,
WSLA_CONTAINER_NETWORK_TYPE ContainerNetworkType = WSLA_CONTAINER_NETWORK_TYPE::WSLA_CONTAINER_NETWORK_HOST,
ProcessFlags Flags = ProcessFlags::Stdout | ProcessFlags::Stderr);

void AddVolume(const std::string& HostPath, const std::string& ContainerPath, bool ReadOnly);
Expand Down