fix: call BundleRegistry.unregister() in bundle remove command #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completes the fix for bundle removal by calling the unregister() method added in amplifier-foundation PR microsoft#9. Previously, 'amplifier bundle remove' only removed bundles from the user registry but left them in the foundation registry's in-memory state. Changes: - Call BundleRegistry.unregister() to remove from foundation registry - Call registry.save() to persist the removal - Provide detailed feedback about which registries were affected - Handle errors gracefully with warning messages Companion PR to: microsoft/amplifier-foundation#9 🤖 Generated with Amplifier Co-Authored-By: Amplifier <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Completes the fix for
amplifier bundle removeby calling theunregister()method added in amplifier-foundation PR #9. Previously, the command only removed bundles from the user registry but left them in the foundation registry's in-memory state.Changes
BundleRegistry.unregister()to remove from foundation registryregistry.save()to persist the removalTest Plan
Related
🤖 Generated with Amplifier
Co-Authored-By: Amplifier [email protected]