feat: Add --format to export command - #70
Merged
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree [company="Microsoft"] |
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
Collaborator
|
jkafrouni (@jkafrouni) please add test covering the export format scenario. You can use notebook .py formatting example in the test |
Collaborator
|
jkafrouni (@jkafrouni) in the description you meant --format and not --export am I correct? |
aviatco
reviewed
Nov 23, 2025
aviatco
reviewed
Nov 23, 2025
aviatco
reviewed
Nov 23, 2025
Contributor
Author
Correct, my bad, just edited |
Contributor
Author
Just added two tests for success and failure |
aviatco
reviewed
Dec 15, 2025
aviatco
reviewed
Dec 16, 2025
aviatco
reviewed
Dec 17, 2025
Alon Yeshurun (ayeshurun)
approved these changes
Dec 24, 2025
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of new changes
Fixes #24 by adding --format to the export command parser and setting the right underlying format if user selects .py or .ipynb, similar to how the import command supports format.
If no format is selected and the user is exporting a notebook, will continue using the default export format for notebooks which is ipynb.