-
Notifications
You must be signed in to change notification settings - Fork 61
feat: Add --format to export command #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aviatco
merged 17 commits into
microsoft:main
from
jkafrouni:dev/notebook_export_formats
Dec 24, 2025
Merged
Changes from 9 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
34bb53e
Add --format to export parser
jkafrouni e181524
Update changie
jkafrouni af55166
Store valid export formats inside definition_format_mapping
jkafrouni a9147e2
Add export error class
jkafrouni ab730a8
Add export success and failure tests
jkafrouni c207a7b
Move export format info to docs
jkafrouni 60b13cf
Add more details in export.md
jkafrouni ddcbeae
recoring new tests with mock data
e341d2e
Merge branch 'main' into dev/notebook_export_formats
ayeshurun 872b5a1
Remove trailing dot in export error message
jkafrouni 5658335
Add test for default format export
jkafrouni 0a03d3b
Use new format mapping correctly in set command
jkafrouni 005d911
add tests and recording; filter default from error message
1169725
merge
7db30e3
record test_export_report_no_format_support_failure
f980a83
update get format logic
2e133f1
remove duplication
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| kind: added | ||
| body: Add --format option to export command to pick .ipynb or .py when exporting notebooks | ||
| time: 2025-11-20T02:54:50.543931335Z | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
aviatco marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Copyright (c) Microsoft Corporation. | ||
| # Licensed under the MIT License. | ||
|
|
||
|
|
||
| class ExportErrors: | ||
| @staticmethod | ||
| def invalid_export_format(valid_formats: list[str]) -> str: | ||
| return f"Invalid format. Only the following formats are supported: {valid_formats}." | ||
|
aviatco marked this conversation as resolved.
Outdated
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.