-
Notifications
You must be signed in to change notification settings - Fork 744
feat(react-icons): enable deteministic chunking when generating chunks #896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
[WIP] [Bug]: adding new icons is causing bundle size regressions
Fix bundle size regressions when adding new icons through stable chunking
Sep 22, 2025
Copilot finished work on behalf of
Hotell
September 22, 2025 17:09
Hotell
reviewed
Oct 13, 2025
Hotell
reviewed
Oct 13, 2025
81792b0 to
a9f463b
Compare
Copilot stopped work on behalf of
Hotell due to an error
October 13, 2025 13:22
Copilot finished work on behalf of
Hotell
October 13, 2025 13:32
Hotell
reviewed
Oct 16, 2025
Hotell
reviewed
Oct 16, 2025
Co-authored-by: Hotell <[email protected]>
Co-authored-by: Hotell <[email protected]>
Co-authored-by: Hotell <[email protected]>
Co-authored-by: Hotell <[email protected]>
Co-authored-by: Hotell <[email protected]>
…ne snapshots Co-authored-by: Hotell <[email protected]>
…emove documentation Co-authored-by: Hotell <[email protected]>
f784941 to
866748d
Compare
|
@copilot tests are failing fix it by running in order:
|
…king Co-authored-by: Hotell <[email protected]>
Copilot finished work on behalf of
Hotell
October 21, 2025 08:31
Hotell
reviewed
Oct 21, 2025
Co-authored-by: Hotell <[email protected]>
|
replaced by #911 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Bundle Size Regressions from Adding New Icons ✅
Problem Analysis:
The current chunking strategy in
packages/react-icons/convert.js/packages/react-icons/convert-font.jsuses sequential chunking (groups of 1000 icons in alphabetical order). When new icons are added, existing icons shift between chunks, causing webpack's SplitChunksPlugin to detect size changes in all chunks, leading to bundle reshuffling and size regressions.Technical Implementation:
chunking-utils.jswith hash-based chunking algorithm usinghash(iconName) % numChunkscrypto.createHash('sha256')for better reliabilitysplice(0, 1000)chunking in bothconvert.jsandconvert-font.jsImpact:
The solution completely resolves the bundle size regression issue preventing Teams from bumping the icons package.
Fixes #881.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.