Add Logical Network Support #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjethwa-msft
force-pushed
the
user/mjethwa-msft/lnet
branch
2 times, most recently
from
e541243
to
c8809c6
Compare
mjethwa-msft
requested review from
nijosmsft,
in3xes,
madhanrm and
JocelynBerrendonner
raghavendra-nataraj
previously approved these changes
Jul 13, 2023
in3xes
reviewed
Jul 14, 2023
rpc/cloudagent/network/logicalnetwork/moc_cloudagent_logicalnetwork.proto
Show resolved
Hide resolved
madhanrm
reviewed
Jul 14, 2023
rpc/cloudagent/network/logicalnetwork/moc_cloudagent_logicalnetwork.proto
Outdated
Show resolved
Hide resolved
madhanrm
reviewed
Jul 14, 2023
rpc/cloudagent/network/logicalnetwork/moc_cloudagent_logicalnetwork.proto
Outdated
Show resolved
Hide resolved
madhanrm
reviewed
Jul 14, 2023
rpc/cloudagent/network/logicalnetwork/moc_cloudagent_logicalnetwork.proto
Outdated
Show resolved
Hide resolved
madhanrm
reviewed
Jul 14, 2023
rpc/cloudagent/network/networkinterface/moc_cloudagent_networkinterface.proto
Outdated
Show resolved
Hide resolved
nijosmsft
reviewed
Jul 18, 2023
| uint32 vlan = 6; | ||
| repeated IPPool ipPools = 7; | ||
| Dns dns = 8 [(sensitive) = true]; | ||
| bool isPublic = 9; // Indicates whether this is a public subnet on a virtual machine. |
mjethwa-msft
force-pushed
the
user/mjethwa-msft/lnet
branch
from
0d0915a
to
1d09743
Compare
mjethwa-msft
force-pushed
the
user/mjethwa-msft/lnet
branch
from
1d09743
to
f7db3c0
Compare
mjethwa-msft
force-pushed
the
user/mjethwa-msft/lnet
branch
from
f7db3c0
to
0286ff6
Compare
in3xes
previously approved these changes
Aug 28, 2023
|
@mjethwa-msft could you rebase your PR? |
mjethwa-msft
force-pushed
the
user/mjethwa-msft/lnet
branch
from
0286ff6
to
487a3da
Compare
rebased. |
mjethwa-msft
force-pushed
the
user/mjethwa-msft/lnet
branch
from
487a3da
to
68cd5d6
Compare
mjethwa-msft
force-pushed
the
user/mjethwa-msft/lnet
branch
from
68cd5d6
to
916f8d0
Compare
mjethwa-msft
force-pushed
the
user/mjethwa-msft/lnet
branch
from
916f8d0
to
7a2891b
Compare
msftpgayam
reviewed
Jan 5, 2024
mjethwa-msft
force-pushed
the
user/mjethwa-msft/lnet
branch
from
7a2891b
to
bd6b177
Compare
msftpgayam
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design Spec: Link
Sample Test Commands: Added to the spec