-
Notifications
You must be signed in to change notification settings - Fork 36
FEAT: Enhance pipeline dependencies and add Python < 3.13 #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for building macOS wheels for Python versions 3.12, 3.11, and 3.10 in the existing matrix configuration.
- Introduces
py312_universal2,py311_universal2, andpy310_universal2entries withpythonVersion,shortPyVer, andtargetArchset touniversal2. - Maintains consistency with the existing macOS universal2 strategy for Python 3.13.
- Leaves room for future version additions in the same pattern.
Comments suppressed due to low confidence (3)
eng/pipelines/build-whl-pipeline.yml:197
- [nitpick] This comment repeats the architecture information already noted above; consider simplifying it to just
# Python 3.12to reduce redundancy.
# Python 3.12 (universal2 for both arm64 and x86_64)
eng/pipelines/build-whl-pipeline.yml:197
- Don’t forget to update any external documentation or README files to list these newly supported Python versions so users are aware of 3.10, 3.11, and 3.12 support.
# Python 3.12 (universal2 for both arm64 and x86_64)
sumitmsft
approved these changes
Jul 2, 2025
jahnvi480
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO Work Item Reference
Summary
This pull request updates the build and validation pipelines to improve compatibility, streamline database setup, and enhance testing workflows. Key changes include updating Python version specifications, adding support for LocalDB and Docker-based SQL Server configurations, and ensuring pytest is run with proper database connections.
Updates to Python version specifications:
3.13.5to3.13across multiple jobs ineng/pipelines/build-whl-pipeline.ymlandeng/pipelines/pr-validation-pipeline.yml, reflecting the availability of the new version. [1] [2] [3]Database setup enhancements:
eng/pipelines/build-whl-pipeline.yml.Testing improvements:
eng/pipelines/build-whl-pipeline.ymlandeng/pipelines/pr-validation-pipeline.yml. Removed reliance on Azure SQL Database for testing on macOS. [1] [2]Expanded Python version support:
3.10,3.11, and3.12withuniversal2architecture for macOS ineng/pipelines/build-whl-pipeline.yml.