Skip to content

Conversation

@bewithgaurav
Copy link
Collaborator

@bewithgaurav bewithgaurav commented Jun 30, 2025

ADO Work Item Reference

AB#37821


Summary

This pull request updates the build and validation pipelines to improve compatibility, streamline database setup, and enhance testing workflows. Key changes include updating Python version specifications, adding support for LocalDB and Docker-based SQL Server configurations, and ensuring pytest is run with proper database connections.

Updates to Python version specifications:

  • Updated Python version from 3.13.5 to 3.13 across multiple jobs in eng/pipelines/build-whl-pipeline.yml and eng/pipelines/pr-validation-pipeline.yml, reflecting the availability of the new version. [1] [2] [3]

Database setup enhancements:

  • Added steps to start a LocalDB instance, create a database, and configure a user for testing in eng/pipelines/build-whl-pipeline.yml.
  • Integrated Docker-based SQL Server setup in both pipelines, including pulling the SQL Server container, starting it, and verifying its operational status. [1] [2]

Testing improvements:

  • Ensured pytest runs with appropriate database connection strings for LocalDB and Docker-based SQL Server setups in eng/pipelines/build-whl-pipeline.yml and eng/pipelines/pr-validation-pipeline.yml. Removed reliance on Azure SQL Database for testing on macOS. [1] [2]

Expanded Python version support:

  • Added jobs for Python versions 3.10, 3.11, and 3.12 with universal2 architecture for macOS in eng/pipelines/build-whl-pipeline.yml.

Copilot AI review requested due to automatic review settings June 30, 2025 11:26
@github-actions github-actions bot added the pr-size: small Minimal code update label Jun 30, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for building macOS wheels for Python versions 3.12, 3.11, and 3.10 in the existing matrix configuration.

  • Introduces py312_universal2, py311_universal2, and py310_universal2 entries with pythonVersion, shortPyVer, and targetArch set to universal2.
  • Maintains consistency with the existing macOS universal2 strategy for Python 3.13.
  • Leaves room for future version additions in the same pattern.
Comments suppressed due to low confidence (3)

eng/pipelines/build-whl-pipeline.yml:197

  • [nitpick] This comment repeats the architecture information already noted above; consider simplifying it to just # Python 3.12 to reduce redundancy.
      # Python 3.12 (universal2 for both arm64 and x86_64)

eng/pipelines/build-whl-pipeline.yml:197

  • Don’t forget to update any external documentation or README files to list these newly supported Python versions so users are aware of 3.10, 3.11, and 3.12 support.
      # Python 3.12 (universal2 for both arm64 and x86_64)

@bewithgaurav bewithgaurav marked this pull request as draft June 30, 2025 11:28
@github-actions github-actions bot added pr-size: small Minimal code update and removed pr-size: small Minimal code update labels Jun 30, 2025
@github-actions github-actions bot added pr-size: medium Moderate update size and removed pr-size: small Minimal code update labels Jun 30, 2025
@github-actions github-actions bot added pr-size: medium Moderate update size and removed pr-size: medium Moderate update size labels Jun 30, 2025
@github-actions github-actions bot added pr-size: medium Moderate update size and removed pr-size: medium Moderate update size labels Jul 1, 2025
@bewithgaurav bewithgaurav changed the title FEAT: Support Python < 3.13 on Unix TEST2: Support Python < 3.13 on Unix Jul 1, 2025
@bewithgaurav bewithgaurav changed the title TEST2: Support Python < 3.13 on Unix TAST: Support Python < 3.13 on Unix Jul 1, 2025
@bewithgaurav bewithgaurav changed the title TAST: Support Python < 3.13 on Unix FEAT: Support Python < 3.13 on Unix Jul 1, 2025
@github-actions github-actions bot added pr-size: medium Moderate update size and removed pr-size: medium Moderate update size labels Jul 1, 2025
@github-actions github-actions bot added pr-size: medium Moderate update size and removed pr-size: medium Moderate update size labels Jul 2, 2025
@bewithgaurav bewithgaurav marked this pull request as ready for review July 2, 2025 05:48
@bewithgaurav bewithgaurav changed the title FEAT: Support Python < 3.13 on Unix FEAT: Add Pytests in Build Pipeline and Support Python < 3.13 Jul 2, 2025
@github-actions github-actions bot added pr-size: medium Moderate update size and removed pr-size: medium Moderate update size labels Jul 2, 2025
@bewithgaurav bewithgaurav changed the title FEAT: Add Pytests in Build Pipeline and Support Python < 3.13 FEAT: Enhance pipeline dependencies and add Python < 3.13 Jul 2, 2025
@github-actions github-actions bot added pr-size: medium Moderate update size and removed pr-size: medium Moderate update size labels Jul 2, 2025
@sumitmsft sumitmsft merged commit 1e2f202 into main Jul 2, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-size: medium Moderate update size

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants