[REBASE && FF][202405][SPLIT]NetworkPkg/UefiPxeBcDxe: Mark the device as removed when it is unplugged #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flickdm
force-pushed
the
cherry-pick/release/202405/feature/unplugged-nic
branch
from
c0b1fde
to
b0febe0
Compare
Flickdm
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202405 #1036 +/- ##
================================================
Coverage ? 0.55%
================================================
Files ? 165
Lines ? 71222
Branches ? 1754
================================================
Hits ? 394
Misses ? 70821
Partials ? 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apop5
reviewed
Jul 12, 2024
apop5
reviewed
Jul 12, 2024
apop5
approved these changes
Jul 12, 2024
os-d
approved these changes
Jul 12, 2024
makubacki
reviewed
Jul 12, 2024
makubacki
approved these changes
Jul 12, 2024
kuqin12
approved these changes
Jul 16, 2024
Flickdm
force-pushed
the
cherry-pick/release/202405/feature/unplugged-nic
branch
2 times, most recently
from
3238150
to
4d1c7e1
Compare
Network stack fails when USB nic is removed after initialization. This change marks it removed but doesn't clean up memory allocations so that other code holding onto and using that memory doesn't cause an exception. This change was split off the commit: microsoft@7a38833
Flickdm
force-pushed
the
cherry-pick/release/202405/feature/unplugged-nic
branch
from
4d1c7e1
to
44fc089
Compare
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Network stack fails when USB nic is removed after
initialization. This change marks it removed but
doesn't clean up memory allocations so that other
code holding onto and using that memory doesn't
cause an exception.
This change was split off the commit:
7a38833
How This Was Tested
Release/202405
Integration Instructions
N/A
Upstream