Upgrade min ios version to 13.0 #20773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgchen1
approved these changes
Jun 4, 2024
jchen351
approved these changes
Jun 4, 2024
snnn
added a commit
that referenced
this pull request
Jan 9, 2025
Update min iOS version to 15.1 to align with React Native 0.76. We need to update React Native . See react-native-community/discussions-and-proposals#812 for background. Similar to PR #20773
tarekziade
pushed a commit
to tarekziade/onnxruntime
that referenced
this pull request
Jan 10, 2025
…soft#23292) Update min iOS version to 15.1 to align with React Native 0.76. We need to update React Native . See react-native-community/discussions-and-proposals#812 for background. Similar to PR microsoft#20773
guschmue
pushed a commit
that referenced
this pull request
Jan 12, 2025
Update min iOS version to 15.1 to align with React Native 0.76. We need to update React Native . See react-native-community/discussions-and-proposals#812 for background. Similar to PR #20773
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To align with Office and other MS products.
Office's support policy is:
"Office for iPad and iPhone is supported on the two most recent versions of iOS and iPadOS. When a new version of iOS or iPadOS is released, the Office Operating System requirement becomes the two most recent versions: the new version of iOS or iPadOS and the previous version." (from https://products.office.com/office-system-requirements)
The latest iOS version is 17. So they support both 17 and 16. Here I set our min iOS version to 13 so that it will be a superset of what Office supports.
This change would allow us using C++17's std::filesystem feature in the core framework. The modifications were generated by running
Cannot use 15.0 because otherwise iOS packaging would fail with:
The Google OSS libraries we use only officially support iOS 15+.