Hint user to upgrade every 7 days for HINT_ACTIVITY_NAME #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 6, 2023 16:47
wangchao1230
reviewed
Dec 7, 2023
wangchao1230
reviewed
Dec 7, 2023
YingChen1996
temporarily deployed
to
internal
GitHub Actions
Inactive
YingChen1996
temporarily deployed
to
internal
GitHub Actions
Inactive
YingChen1996
temporarily deployed
to
internal
GitHub Actions
Inactive
YingChen1996
temporarily deployed
to
internal
GitHub Actions
Inactive
YingChen1996
temporarily deployed
to
internal
GitHub Actions
Inactive
YingChen1996
temporarily deployed
to
internal
GitHub Actions
Inactive
YingChen1996
temporarily deployed
to
internal
GitHub Actions
Inactive
YingChen1996
temporarily deployed
to
internal
GitHub Actions
Inactive
YingChen1996
temporarily deployed
to
internal
GitHub Actions
Inactive
zhengfeiwang
previously approved these changes
Dec 21, 2023
wangchao1230
previously approved these changes
Dec 21, 2023
YingChen1996
dismissed stale reviews from wangchao1230 and zhengfeiwang
via
16906af
YingChen1996
temporarily deployed
to
internal
GitHub Actions
Inactive
YingChen1996
temporarily deployed
to
internal
GitHub Actions
Inactive
YingChen1996
temporarily deployed
to
internal
GitHub Actions
Inactive
YingChen1996
temporarily deployed
to
internal
GitHub Actions
Inactive
YingChen1996
temporarily deployed
to
internal
GitHub Actions
Inactive
YingChen1996
temporarily deployed
to
internal
GitHub Actions
Inactive
wangchao1230
approved these changes
Dec 21, 2023
D-W-
approved these changes
Dec 21, 2023
D-W-
reviewed
Dec 21, 2023
| hint_for_update() | ||
| with ThreadPoolExecutor(max_workers=concurrent_count) as pool: | ||
| pool.submit(check_latest_version) | ||
|
|
There was a problem hiding this comment.
Will there be cases check_latest_version not finished when running the following line?
There was a problem hiding this comment.
No, we won't check since Clement suggests may not break user because of get pypi.
D-W-
reviewed
Dec 21, 2023
| mock_datetime.datetime.strptime.return_value = datetime.datetime.now() - datetime.timedelta(days=8) | ||
| mock_datetime.timedelta.return_value = datetime.timedelta(days=7) | ||
| hint_for_update() | ||
| with ThreadPoolExecutor(max_workers=concurrent_count) as pool: |
There was a problem hiding this comment.
How does max_workers impact check_latest_version's behavior?
There was a problem hiding this comment.
Actually, this is added when hint_for_update and check_latest_version need to be run in one thread pool and I need check the file is well writen in max_workers. Will update this test in later pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
promptflowpackage, adding new test methods, constants, and modules related to version hinting and checking. The most important changes include adding a new test method with parameterized values, adding new constants to theAvailableIDEclass, and adding a new module for version hinting and checking.Main changes:
src/promptflow/tests/sdk_cli_test/unittests/test_utils.py: Added a new test methodtest_concurrent_hint_for_updatewith parameterized values forconcurrent_count.src/promptflow/promptflow/_constants.py: Added new constants related to version hinting and checking in theAvailableIDEclass.src/promptflow/promptflow/_utils/version_hint_utils.py: Added a new moduleversion_hint_utils.pywith functions for version hinting and checking.Please add an informative description that covers that changes made by the pull request and link all relevant issues.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines