Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hint user to upgrade every 7 days for HINT_ACTIVITY_NAME #1407
Hint user to upgrade every 7 days for HINT_ACTIVITY_NAME #1407
Changes from all commits
894eb47
fc0249b
5277897
91cf864
83b0d61
be7e56d
7abdf12
f7f8d11
67dd035
ba4c177
69996a1
a3f084a
6a502a0
740ec8a
0d7e553
851bcf2
5d8e1c8
5444737
2f777f1
04a6a21
8fa7c10
f075f73
e3e4c59
27e8ebd
dececa9
0c2c38e
73486e3
a84f728
124b5b6
827cb54
c898b7c
fd4a46c
c8f16a8
3a46cf2
9bcc3f2
021b6ef
b8bf5ca
bad7b08
6d2aefb
97d7a10
16906af
c5c1035
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does max_workers impact
check_latest_version
's behavior?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this is added when hint_for_update and check_latest_version need to be run in one thread pool and I need check the file is well writen in max_workers. Will update this test in later pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will there be cases check_latest_version not finished when running the following line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we won't check since Clement suggests may not break user because of get pypi.