Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dropped ledger columns from Edit Data columns #1691

Merged
merged 3 commits into from
Sep 19, 2022
Merged

Remove dropped ledger columns from Edit Data columns #1691

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21470b0
remove dropped ledger columns from Edit Data columns
nofield Sep 15, 2022
b6e5707
moving dropped ledger filtering to column retrieval from SMO
nofield Sep 19, 2022
b352be0
fix clear and initialize placement and retrieve DefaultConstraintName
nofield Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Microsoft.SqlTools.ServiceLayer/EditData/SmoEditMetadataFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ public EditTableMetadata GetObjectMetadata(DbConnection connection, string[] obj
throw new ArgumentOutOfRangeException(nameof(objectType), SR.EditDataUnsupportedObjectType(objectType));
}

// Filter out dropped ledger columns from the list of columns to be returned
//
smoResult.Columns.ClearAndInitialize("[(@IsDroppedLedgerColumn=0)]", new [] {nameof(Column.IsDroppedLedgerColumn), nameof(Column.DataType)});
nofield marked this conversation as resolved.
Show resolved Hide resolved

// A bug in SMO makes it necessary to call refresh to attain certain properties (such as IsMemoryOptimized)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// A bug in SMO

what bug is that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm not sure what that's referring to.

smoResult.Refresh();
if (smoResult.State != SqlSmoState.Existing)
Expand Down