Customizations modal redesign by hawkticehurst · Pull Request #322043 · microsoft/vscode

Hawk Ticehurst (hawkticehurst) · 2026-06-19T05:29:07Z

Summary

This PR substantially redesigns the AI Customizations management editor so it can act as the central place to discover, create, inspect, enable, disable, install, migrate, and manage the customizations available to the active agent harness.

The update covers both the regular VS Code workbench and the Agents window. It replaces the previous mostly list-oriented experience with a harness-aware overview, richer card and inventory surfaces, embedded detail pages, responsive layouts, and consistent navigation across agents, skills, instructions, hooks, prompts, MCP servers, plugins, models, and tools.

User experience changes

New overview and navigation

Adds a customization overview page with:
- a harness-specific heading and introduction;
- cards for the sections supported by the active harness;
- direct creation entry points for prompt-based customizations;
- standalone Voice Mode and Dictation instruction launchers where supported;
- migration cards when deprecated or incompatible customizations are detected.
Reworks the editor sidebar around:
- a dedicated Overview entry;
- harness-filtered sections;
- live per-section item counts;
- migration shortcuts and counts;
- persisted section selection;
- focus transfer to each section's search field when navigating.
Includes the active customization target in the editor title and keeps the editor synchronized with the active Agents-window session and harness.
Updates the Agents-window customization toolbar to use the same model-backed counts and harness visibility rules as the editor.

Agents, skills, instructions, hooks, and prompts

Introduces card-based inventories for agents, skills, instructions, and hooks while retaining the list presentation where appropriate for prompts.
Groups items by their actual source, including workspace, user, plugin, extension, built-in, and provider-backed remote sources.
Adds richer secondary text, source descriptions, badges, search highlighting, item counts, and empty states.
Adds inline item actions and overflow menus while preserving the existing prompt context-menu behavior.
Keeps editable source sections available for creation even when they are empty, and hides empty sections only once search filtering begins.
Improves keyboard behavior and accessibility through:
- native/shared button widgets for actionable controls;
- keyboard activation for cards;
- focused-row action tab stops;
- localized ARIA labels;
- search-result count announcements;
- explicit focus restoration and section focus behavior.
Adds a structured preview mode for prompt-based files, including metadata/body rendering, field help, validation issues, and a raw-source fallback.

Customization migration

Adds independently gated migration flows for:
- converting deprecated workspace and user *.prompt.md files into skills;
- moving legacy User Data customizations into locations supported by the active harness.
Presents candidates in source-based groups with:
- per-item and per-group selection;
- tri-state group checkboxes;
- embedded file preview;
- delete actions;
- destination-aware explanatory copy and confirmation.
Preserves source formatting where possible, reports unsupported metadata for review, continues after individual file failures, and reveals successfully migrated files.
Protects migration integrity by:
- binding the operation to the initiating active session;
- avoiding target overwrite;
- migrating duplicate source identities before source deletion;
- rolling back a newly written target when source deletion fails;
- allowing users to keep the original files.

MCP servers

Reworks MCP management into a card-based home surface with installed and marketplace sections.
Supports marketplace discovery, search, installation, and direct reveal of available servers.
Adds richer installed-server rows with:
- connection and enablement status;
- profile/workspace/session enablement actions;
- start/stop/restart actions;
- output and configuration actions;
- plugin-owned server handling;
- disabled-reason presentation.
Adds embedded MCP detail pages with source, scope, status, configuration/definition information, and back-navigation.
Preserves enterprise/user access gating and provides the appropriate policy or Settings explanation when MCP access is disabled.

Plugins

Adds a redesigned plugin home with installed, remote, recommended, and marketplace content.
Adds marketplace browse and search modes that combine:
- installed plugins;
- provider-backed remote plugins;
- marketplace results available to install.
Adds plugin creation, install-from-source, update, install, uninstall, and enablement actions.
Adds embedded plugin detail pages with:
- marketplace/source provenance;
- installation path and copy action;
- inclusion/enablement state;
- policy-blocked state;
- install/enable/disable/uninstall actions;
- grouped inventories for contributed agents, skills, instructions, hooks, MCP servers, and commands;
- navigation from a contribution to the corresponding customization section or file.
Extends marketplace metadata with recommended-plugin information used by the redesigned home surface.

Tools

Reworks the tools section into source-based inventories for:
- built-in tools;
- MCP/user-connected sources;
- extension-contributed tools.
Adds expandable tool sets, per-set and per-tool enablement, search, keyboard navigation, and read-only handling for provider-owned sets.
Adds marketplace browsing for extensions that contribute language-model tools, including manifest filtering and Agents-window execution constraints.
Adds embedded tool-set detail navigation and extension management actions.

Responsive layout and presentation

Introduces shared presentation helpers so display names, source labels, inclusion state, and card/list behavior remain consistent.
Adds narrow and wide responsive states for the management editor, inventories, cards, and embedded details.
Updates visual hierarchy, spacing, focus treatment, overflow behavior, scrollable regions, badges, section headers, action placement, and high-density layouts across the editor.
Keeps list and card layouts synchronized with their actual rendered dimensions after section changes and responsive reflow.

Architecture and consistency

Keeps section counts and rendered prompt-based items on the same IAICustomizationItemsModel pipeline.
Applies harness visibility and provider behavior declaratively instead of branching on individual harness IDs in shared widgets.
Keeps Agents-window project/session context synchronized with the shared management editor.
Preserves AI-feature gating and harness-specific section availability.
Uses the owning MCP, plugin, prompts, tool, workspace, and harness services rather than duplicating customization state in the UI.

Tests and fixtures

This PR expands focused coverage for:

prompt-based grouping, source extraction, card behavior, search, layout fallback, and count announcements;
management-editor title, preview, migration gating, selection, grouping, focus, and navigation;
migration conversion, formatting preservation, partial failures, duplicate sources, rollback, concurrent target creation, and keeping originals;
MCP enablement actions, plugin-owned servers, no-op row updates, inline actions, output routing, source grouping, and session/workspace behavior;
plugin disabled reasons and scope-preserving enablement;
overview/migration card native interaction behavior.

The component fixture coverage now includes the overview and all major sections in light/dark themes, narrow layouts, browse/search states, migration flows, empty/disabled states, and embedded MCP/plugin detail pages.

Suggested manual verification

Open Customizations in the regular workbench and in the Agents window.
Switch between available harnesses/sessions and verify the title, visible sections, counts, overview cards, and project context update together.
Exercise keyboard-only navigation through the overview, sidebar, search fields, cards, row actions, and detail-page back buttons.
Verify search, creation, editing, structured preview, and source grouping for agents, skills, instructions, hooks, and prompts.
Exercise both migration categories, including partial selection, preview, keeping originals, and switching the active session during confirmation.
Search/browse/install/manage MCP servers and plugins, including disabled-by-setting and disabled-by-policy states.
Inspect installed and marketplace plugin details and open contributed customizations from the contribution inventory.
Expand, search, enable/disable, and browse extension-contributed tool sets.
Resize the editor through narrow and wide layouts and verify no cards, badges, actions, or scroll regions clip.
Check the main fixtures in light, dark, and high-contrast themes.

Screenshots

Copilot

Pull request overview

This PR prototypes a redesigned Plugins experience in the AI Customizations management editor, shifting the default surface toward a card-based “home” while retaining WorkbenchList for search and list-based interactions.

Changes:

Introduces a card-based plugins home surface, plus a browse/search experience that mixes installed/remote/marketplace results.
Enhances plugin detail rendering to include provenance/facts, contribution inventory, and inline management actions.
Updates styling and component fixtures to support the redesigned layouts and new marketplace recommendation signal (recommendedPlugins).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/vs/workbench/test/browser/componentFixtures/sessions/aiCustomizationManagementEditor.fixture.ts	Updates fixture mocks (adds `recommendedPlugins`) and switches browse-mode activation to the widget API.
src/vs/workbench/contrib/chat/browser/aiCustomization/pluginListWidget.ts	Reworks plugin list UI: card home surface, search headers, recommended badges, and marketplace/installed search blending.
src/vs/workbench/contrib/chat/browser/aiCustomization/media/aiCustomizationManagement.css	Adds/adjusts CSS for the new plugin list rows, card surfaces, and richer embedded detail layout.
src/vs/workbench/contrib/chat/browser/aiCustomization/embeddedAgentPluginDetail.ts	Expands embedded plugin detail with install/enable/disable/uninstall actions, facts, copy path, and grouped contributions.
src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagementEditor.ts	Wires new embedded-detail events to open contributed artifacts/sections and handle uninstall navigation.
src/vs/sessions/AI_CUSTOMIZATIONS.md	Documents the new Plugins section UX and behaviors.

github-actions · 2026-06-19T05:37:31Z

Screenshot Changes

Base: 56e38668 Current: b57044c2

Changed (88)

sessions/aiCustomizationShortcutsWidget/Expanded/Dark

Before	After

sessions/aiCustomizationShortcutsWidget/Expanded/Light

Before	After

sessions/aiCustomizationShortcutsWidget/MinimumHeight/Dark

Before	After

sessions/aiCustomizationShortcutsWidget/MinimumHeight/Light

Before	After

sessions/aiCustomizationShortcutsWidget/WithMcpServers/Dark

Before	After

sessions/aiCustomizationShortcutsWidget/WithMcpServers/Light

Before	After

sessions/aiCustomizationShortcutsWidget/MinimumHeightWithMcpServers/Dark

Before	After

sessions/aiCustomizationShortcutsWidget/MinimumHeightWithMcpServers/Light

Before	After

sessions/aiCustomizationShortcutsWidget/WithCounts/Dark

Before	After

sessions/aiCustomizationShortcutsWidget/WithCounts/Light

Before	After

chat/aiCustomizations/aiCustomizationListWidget/InstructionsTabWithItems/Dark

Before	After

chat/aiCustomizations/aiCustomizationListWidget/InstructionsTabWithItems/Light

Before	After

chat/aiCustomizations/aiCustomizationListWidget/InstructionsTabEmpty/Dark

Before	After

chat/aiCustomizations/aiCustomizationListWidget/InstructionsTabEmpty/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/WelcomePage/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/WelcomePage/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/LocalHarness/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/LocalHarness/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/AgentHostPromptMigration/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/AgentHostPromptMigration/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/Sessions/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/Sessions/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/SessionsSkillsTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/SessionsSkillsTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTabActiveSession/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTabActiveSession/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/SkillsTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/SkillsTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/InstructionsTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/InstructionsTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/HooksTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/HooksTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PromptMigration/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PromptMigration/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/UserDataMigration/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/UserDataMigration/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PluginBrowseMode/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PluginBrowseMode/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTabScrolled/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTabScrolled/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTabScrolled/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTabScrolled/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTabScrolled/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTabScrolled/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTabNarrow/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTabNarrow/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTabNarrow/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTabNarrow/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/AgentsItemPreview/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/AgentsItemPreview/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/AgentsItemRaw/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/AgentsItemRaw/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/BuiltinSkillItemPreview/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/BuiltinSkillItemPreview/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/BuiltinSkillItemRaw/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/BuiltinSkillItemRaw/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpServerDetail/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpServerDetail/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpServerDetailNarrow/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpServerDetailNarrow/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PluginDetail/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PluginDetail/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PluginDetailNarrow/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PluginDetailNarrow/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedMcpDetailWorkspace/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedMcpDetailWorkspace/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedMcpDetailUser/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedMcpDetailUser/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedMcpDetailEmpty/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedMcpDetailEmpty/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedPluginDetailInstalled/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedPluginDetailInstalled/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedPluginDetailMarketplace/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedPluginDetailMarketplace/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedPluginDetailEmpty/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedPluginDetailEmpty/Light

Before	After

chat/aiCustomizations/aiCustomizationWelcomePages/WelcomePage/Dark

Before	After

chat/aiCustomizations/aiCustomizationWelcomePages/WelcomePage/Light

Before	After

1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.

Added (48)

chat/aiCustomizations/aiCustomizationManagementEditor/WelcomePageNarrow/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/WelcomePageNarrow/Light

chat/aiCustomizations/aiCustomizationManagementEditor/McpServersSearch/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/McpServersSearch/Light

chat/aiCustomizations/aiCustomizationManagementEditor/McpServersAuthRequired/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/McpServersAuthRequired/Light

chat/aiCustomizations/aiCustomizationManagementEditor/McpServerActiveSessionDetail/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/McpServerActiveSessionDetail/Light

chat/aiCustomizations/aiCustomizationManagementEditor/AgentsSearch/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/AgentsSearch/Light

chat/aiCustomizations/aiCustomizationManagementEditor/AgentsEmptyUser/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/AgentsEmptyUser/Light

chat/aiCustomizations/aiCustomizationManagementEditor/RemoteSkillsTab/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/RemoteSkillsTab/Light

chat/aiCustomizations/aiCustomizationManagementEditor/HooksEmptyWorkspace/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/HooksEmptyWorkspace/Light

chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTabNarrow/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTabNarrow/Light

chat/aiCustomizations/aiCustomizationManagementEditor/PromptMigrationNarrow/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/PromptMigrationNarrow/Light

chat/aiCustomizations/aiCustomizationManagementEditor/PromptMigrationPartialSelection/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/PromptMigrationPartialSelection/Light

chat/aiCustomizations/aiCustomizationManagementEditor/PromptMigrationEmptyUser/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/PromptMigrationEmptyUser/Light

chat/aiCustomizations/aiCustomizationManagementEditor/ToolsTab/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/ToolsTab/Light

chat/aiCustomizations/aiCustomizationManagementEditor/ToolsTabNarrow/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/ToolsTabNarrow/Light

chat/aiCustomizations/aiCustomizationManagementEditor/ToolsSearchEmpty/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/ToolsSearchEmpty/Light

chat/aiCustomizations/aiCustomizationManagementEditor/ToolsEmptyExtensions/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/ToolsEmptyExtensions/Light

chat/aiCustomizations/aiCustomizationManagementEditor/SessionsPluginsTab/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/SessionsPluginsTab/Light

chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHome/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHome/Light

chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogSearch/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogSearch/Light

chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHomeNarrow/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHomeNarrow/Light

chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHomeEmptyInstalled/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHomeEmptyInstalled/Light

chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTabNarrow/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTabNarrow/Light

chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedPluginDetailExcludedWorkspace/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedPluginDetailExcludedWorkspace/Light

chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedPluginDetailPolicyBlocked/Dark

chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedPluginDetailPolicyBlocked/Light

SteVen Batten (sbatten)

🤖 AI review verdict: request changes.

I found several functional and accessibility regressions in the redesigned card surfaces, including a recurrence of the MCP node-replacement bug fixed in #330890 and removal of the Settings Sync warning added in #331529. In addition to the inline findings, two required checks are red:

Compile & Hygiene fails because the new editor title contains an unsupported U+2013 character (inline comment below).
Screenshots & Tests passes Playwright, capture, and fixture-error checks, but fails because the newly gated blocks-CI hashes were not committed. Please review the visual diffs and update test/componentFixtures/blocks-ci-screenshots.md using the CI-generated hashes.

No high-confidence exploitable security issue was found, but the known MCP regression, keyboard/accessibility failures, migration data-availability regression, and required-check failures make this not ready to merge.

Hawk Ticehurst (hawkticehurst) · 2026-08-26T20:13:55Z

Follow-up on the overall AI review verdict: the review was high-signal and the inline findings were substantively valid (with the :has() portion already outdated on the latest head). The deterministic Compile & Hygiene finding is fixed and the full hygiene task passes locally.

The blocks-CI screenshot warning was also valid for the reviewed commit. I reviewed the affected customization fixtures locally: 16 selected fixtures render without errors, and 10 dark/light/default/narrow fixtures are stable across three captures. I have not written screenshot hashes from macOS because blocks-ci-screenshots.md must use the PNG hashes produced by the Ubuntu CI job, and the follow-up changes alter gated fixtures again. The next pushed commit should use the CI-generated hash patch after the visual diff is reviewed.

For bot refinement, it would help to separate durable code findings from transient check-state findings and re-check the latter against the latest PR head before posting. That keeps an otherwise excellent review actionable across a fast-moving branch.

…lity - Enhance aiCustomizationListWidget and related management editors. - Introduce aiCustomizationPresentation for better UI handling. - Update styles in aiCustomizationManagement.css for consistency. - Improve tests for aiCustomization components to ensure reliability.

- Improve aiCustomizationManagementEditor and associated components - Enhance styling in aiCustomizationManagement and welcome prompt - Update tests for aiCustomizationManagementEditor and welcome page

- Update agent host sessions provider for better integration. - Enhance AI customization management editor and presentation. - Optimize embedded agent plugin and MCP server details. - Clean up CSS for AI customization management. - Adjust tests to reflect changes in AI customization components.

Route failed-turn resume through the provider service and use the existing provider registration helper in its tests.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

SteVen Batten (sbatten)

🤖 AI second-pass review: request changes.

The findings from the first review were addressed, including the shared composite-list accessibility work, migration disclosure, README render guard/status handling, hygiene, and CSS cleanup. This pass found eight additional issues in the revised paths; the highest priority is a remaining session-backed variant of the MCP node-replacement bug fixed by #330890.

Current CI has 35 passing checks and one pending. The only failure is Screenshots & Tests: fixture tests, screenshot capture, and fixture error checks pass, but the updated blocks-CI screenshot hashes have not been committed.

roblourens

[Experimental performance review bot]

Human-approved experimental performance review.

(Written by Copilot)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Preserve live MCP and plugin detail controls, map remote MCP resources correctly, defer marketplace and editor work until visible, scope hook discovery by storage, and make card-list metadata linear.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Keep Agent Host provider mapping compatible with lightweight providers and accept the reviewed component screenshot baselines generated by CI.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

SteVen Batten (sbatten)

🤖 Third-pass review complete at current PR head 58b049a911f827443e0eaa195980f123e2f5b71a.

No new findings.

This pass was deliberately limited to changes after the second reviewed head:

4c2a49ed: fixes for the eight second-pass comments;
c4a03bb1: CI/screenshot baseline fixes;
58b049a9: subsequent merge from main, reviewing only its three combined conflict resolutions.

All eight second-pass fixes were verified, and no regressions introduced by those fixes were found. Compile/hygiene and the relevant platform/unit checks pass. The refreshed component-fixture run has no Playwright, render, or fixture errors; its current failure is only another blocks-CI screenshot hash mismatch after the latest merge.

Accept the reviewed Agent Host migration and welcome-page hashes generated by the blocks-CI Ubuntu run.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Dmitriy Vasyura (dmitrivMS) · 2026-08-27T18:53:39Z

+				.map(marketplacePluginToItem);
+			this.searchInput.hideMessage();
+		} catch {
+			this.marketplaceItems = [];


AI Review: Each non-browse search cancels the previous token, but this catch ignores cancellation and request identity. If an older fetch rejects after a newer request succeeds, it clears the newer marketplace results, shows a stale warning, and refilters; clearing the query also leaves pending work active. Cancel delayed and in-flight work when the query clears, and only mutate results or messages when the CTS, query, and browse mode still match the initiating request.

Dmitriy Vasyura (dmitrivMS) · 2026-08-27T18:53:39Z

+				getActions: () => {
+					const state = getPluginEnablementActionState(item.plugin.enablement.get());
+					return [
+						this.renderDisposables.add(new Action(`plugin.${state.isEnabled ? 'exclude' : 'include'}AlternateScope`, state.alternateLabel, undefined, true, async () => setEnablement(state.alternateState)))


AI Review: Every dropdown click creates a new caller-owned Action and retains it in the detail-wide renderDisposables until the detail rerenders or closes. ButtonWithDropdown disposes its menu view items, not these actions, so repeatedly opening the menu accumulates emitters and callbacks. Reuse one action per rendered button, return an unregistered lightweight action, or dispose actions when each menu closes.

Dmitriy Vasyura (dmitrivMS) · 2026-08-27T18:53:39Z

-			: localize('searchMcpPlaceholder', "Type to search...")
-		);
+		try {
+			const pager = await this.mcpWorkbenchService.queryGallery(undefined, cts.token);


AI Review: This gallery request is still reachable when the effective chat.mcp.access value is none, including when policy-enforced. Selecting the MCP section can therefore issue a marketplace GET even though access-disabled UI is shown, and revocation leaves delayed or in-flight searches alive. Include effective access in snapshot/search eligibility and cancel delayedGallerySearch plus galleryCts when access becomes none; cover initial disabled visibility and revocation in tests.

Dmitriy Vasyura (dmitrivMS) · 2026-08-27T18:53:39Z

+					if (this._store.isDisposed || this.current !== item) {
+						return;
+					}
+					const installed = this.getInstalledPluginForMarketplaceItem(item);


AI Review: A successful install updates installed descriptors before MarketplaceAgentPluginDiscovery asynchronously publishes the plugin through IAgentPluginService.plugins, so this immediate lookup can miss. The detail does not observe the later publication and has no missing-result recovery, leaving the action disabled as Installing... until the view is recreated. Await or observe discovery of the expected URI, or return the installed plugin explicitly, and restore Install if registration never appears.

Dmitriy Vasyura (dmitrivMS) · 2026-08-27T18:53:39Z

+		switchElement.title = blocked ? localize('pluginPolicyBlockedSwitch', "This plugin is managed by your organization.") : toggleLabel;
+		DOM.append(switchElement, $('.plugin-enable-switch-thumb'));
+		this.cardDisposables.add(DOM.addDisposableListener(switchElement, 'click', () => {
+			const nextState = getToggledPluginEnablementState(current);


AI Review: This derives the transition from enablement captured when the row rendered, then the model update triggers an asynchronous full-card refresh. Before that refresh finishes, repeated activation writes the same transition while the live class and ARIA state remain stale; once it finishes, rebuilding cardContainer detaches the focused switch without restoring focus. Read current enablement per activation and update the row in place, or synchronously bind its state and restore the same row/action after rendering.

Dmitriy Vasyura (dmitrivMS) · 2026-08-27T18:53:39Z

+			uninstallButton.label = uninstallAction.label;
+			uninstallButton.enabled = uninstallAction.enabled;
+			this.renderDisposables.add(uninstallButton.onDidClick(async () => {
+				await uninstallAction.run();


AI Review: The active remove contract is void, but CLI and extension implementations are async and await confirmation. UninstallPluginAction discards that runtime promise and resolves immediately, so this await navigates back while confirmation is pending, including when the user later cancels or removal fails. Return an awaited success result from removal, propagate it through the action, and navigate only after confirmed success.

Dmitriy Vasyura (dmitrivMS) · 2026-08-27T18:53:39Z

+	private setInstalledEntryEnabled(entry: IMcpInstalledEntry, enabled: boolean): void {
+		const activeSessionServer = getActiveSessionServer(entry);
+		if (activeSessionServer) {
+			activeSessionServer.setEnabled(enabled);


AI Review: For an installed row with an active-session counterpart, this unqualified Enable/Disable switch writes only a Session decision and leaves profile/workspace enablement unchanged. A new session can therefore show the server enabled again even though the switch appeared to disable it generally. Label this control as session-scoped or have the primary switch update the durable/default scope.

Dmitriy Vasyura (dmitrivMS) · 2026-08-27T18:53:39Z

+				const source = item.source;
+				const isWorkspaceFile = source === AICustomizationSources.local;
+				const isReadOnly = !source || source === AICustomizationSources.extension || source === AICustomizationSources.plugin || source === AICustomizationSources.builtin;
+				this.showEmbeddedEditor(item.uri, item.name, item.promptType, source ?? AICustomizationSources.builtin, isWorkspaceFile, isReadOnly);


AI Review: The two preceding section-load awaits are not tied to the initiating navigation. If the user selects another section or view while either is pending, this stale continuation can still open the old plugin contribution and replace the newer destination. Track a navigation generation or cancellation token and recheck the requested section/view before calling showEmbeddedEditor.

Hawk Ticehurst (hawkticehurst) self-assigned this Jun 19, 2026

Copilot AI review requested due to automatic review settings June 19, 2026 05:29

Hawk Ticehurst (hawkticehurst) changed the title ~~Prototype design for plugin page in customizations modal~~ Prototype redesign of customizations plugin page Jun 19, 2026

Copilot started reviewing on behalf of Hawk Ticehurst (hawkticehurst) June 19, 2026 05:29 View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Hawk Ticehurst (hawkticehurst) changed the title ~~Prototype redesign of customizations plugin page~~ Customization modal redesign Aug 24, 2026

Hawk Ticehurst (hawkticehurst) changed the title ~~Customization modal redesign~~ Customizations modal redesign Aug 24, 2026

Hawk Ticehurst (hawkticehurst) force-pushed the agents/can-you-kick-off-a-pi-coding-agent-3d251f1f branch from 67e3b40 to 975841b Compare August 25, 2026 18:09

SteVen Batten (sbatten) requested changes Aug 25, 2026

View reviewed changes

Dmitriy Vasyura (dmitrivMS) reviewed Aug 26, 2026

View reviewed changes

Hawk Ticehurst (hawkticehurst) added 9 commits August 26, 2026 17:23

Add prototype design for plugin page in customizations modal

49f790a

More updates/tweaks

bbfe8cc

More updates/tweaks

81a8560

More updates

c1e3fb6

Refactor AI customization management and update related tests

2db2560

- Improve aiCustomizationManagementEditor and associated components - Enhance styling in aiCustomizationManagement and welcome prompt - Update tests for aiCustomizationManagementEditor and welcome page

Refactor AI customization components and update related tests

f50d5bc

Refactor AI customization components and add new tests for coverage

e1d29dd

Hawk Ticehurst (hawkticehurst) force-pushed the agents/can-you-kick-off-a-pi-coding-agent-3d251f1f branch from 0713a7a to e1d29dd Compare August 26, 2026 21:29

Hawk Ticehurst (hawkticehurst) marked this pull request as ready for review August 26, 2026 21:30

Fix AgentService provider refactor compilation

ae7e4ac

Route failed-turn resume through the provider service and use the existing provider registration helper in its tests.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

SteVen Batten (sbatten) requested changes Aug 26, 2026

View reviewed changes

roblourens previously approved these changes Aug 27, 2026

View reviewed changes

roblourens reviewed Aug 27, 2026

View reviewed changes

Hawk Ticehurst (hawkticehurst) and others added 2 commits August 27, 2026 10:02

Merge origin/main into customization editor updates

8096902

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Hawk Ticehurst (hawkticehurst) dismissed roblourens’s stale review via 4c2a49e August 27, 2026 14:28

Fix customization CI regressions

c4a03bb

Keep Agent Host provider mapping compatible with lightweight providers and accept the reviewed component screenshot baselines generated by CI.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Hawk Ticehurst (hawkticehurst) requested a review from SteVen Batten (sbatten) August 27, 2026 14:56

Merge origin/main into customization editor updates

58b049a

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

SteVen Batten (sbatten) previously approved these changes Aug 27, 2026

View reviewed changes

Update customization screenshot baselines

acd7dd6

Accept the reviewed Agent Host migration and welcome-page hashes generated by the blocks-CI Ubuntu run.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Hawk Ticehurst (hawkticehurst) dismissed SteVen Batten (sbatten)’s stale review via acd7dd6 August 27, 2026 17:21

Hawk Ticehurst (hawkticehurst) enabled auto-merge (squash) August 27, 2026 18:18

roblourens approved these changes Aug 27, 2026

View reviewed changes

Dmitriy Vasyura (dmitrivMS) approved these changes Aug 27, 2026

View reviewed changes

Hawk Ticehurst (hawkticehurst) merged commit 2adee83 into main Aug 27, 2026
37 checks passed

Hawk Ticehurst (hawkticehurst) deleted the agents/can-you-kick-off-a-pi-coding-agent-3d251f1f branch August 27, 2026 18:21

vs-code-engineering Bot added this to the 1.136.0 milestone Aug 27, 2026

Dmitriy Vasyura (dmitrivMS) reviewed Aug 27, 2026

View reviewed changes

This was referenced Aug 27, 2026

Address follow up customization modal redesign PR feedback #333027

Merged

Test: Customizations modal redesign #333535

Closed

vs-code-engineering Bot added the on-testplan label Aug 31, 2026

Uh oh!

Conversation

Hawk Ticehurst (hawkticehurst) commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

User experience changes

New overview and navigation

Agents, skills, instructions, hooks, and prompts

Customization migration

MCP servers

Plugins

Tools

Responsive layout and presentation

Architecture and consistency

Tests and fixtures

Suggested manual verification

Screenshots

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshot Changes

Changed (88)

Added (48)

Uh oh!

SteVen Batten (sbatten) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hawk Ticehurst (hawkticehurst) commented Aug 26, 2026

Uh oh!

SteVen Batten (sbatten) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

roblourens left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SteVen Batten (sbatten) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Hawk Ticehurst (hawkticehurst) commented Jun 19, 2026 •

edited

Loading

github-actions Bot commented Jun 19, 2026 •

edited

Loading