Render a window shadow on the floating chat input window - #331225
Closed
Megan Rogge (meganrogge) with Copilot wants to merge 2 commits into
Closed
Render a window shadow on the floating chat input window#331225Megan Rogge (meganrogge) with Copilot wants to merge 2 commits into
Megan Rogge (meganrogge) with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix rendering of window shadow in Electron
Render a window shadow on the floating chat input window
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Omni chat input hosts its content in a frameless, transparent auxiliary window sized tightly to the input. With no chrome and no shadow, it doesn't read as a separate window and gets mistaken for an inline input box.
Since the window bounds hug the surface, a
box-shadowalone would be clipped at the window edge. The fix reserves a transparent gutter around the surface and grows the window bounds by that gutter, so the shadow renders into the transparent band while the input keeps its exact content size.media/chatInputWindow.css— introduce--omni-window-shadow-size: 16px, drive the surfacemargin/heightcalc from it (replacing the 1px stroke), and addbox-shadow: 0 3px 10px 0 var(--vscode-widget-shadow, …)(matching the shadow token used by suggest/action widgets).chatInputWindowService.ts— addCHAT_INPUT_WINDOW_SHADOW_SIZE = 16(kept in sync with the CSS var);fitWindowToInputand_defaultBoundsnow pad width/height by2 * shadowso the surface size is preserved and the shadow isn't clipped.Pending-approval panel sizing and action-widget anchoring measure relative
getBoundingClientRect()s, so the inset gutter is transparent to them.