Skip to content

Render a window shadow on the floating chat input window #331225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Render a window shadow on the floating chat input window #331225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
090ac6c
Initial plan
Copilot Aug 17, 2026
81415fc
Add window shadow to floating chat input window
Copilot Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/vs/workbench/contrib/chat/browser/chatInputWindow/chatInputWindowService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ const CHAT_INPUT_WINDOW_ACTION_WIDGET_HEIGHT = 420;
const CHAT_INPUT_WINDOW_ACTION_WIDGET_WIDTH = 420;
const CHAT_INPUT_WINDOW_ACTION_WIDGET_MARGIN = 4;
const CHAT_INPUT_WINDOW_INITIAL_SURFACE_HEIGHT = 44;
// Transparent gutter around the surface so the CSS window shadow is not clipped
// by the frameless window bounds. Keep in sync with --omni-window-shadow-size in
// media/chatInputWindow.css.
const CHAT_INPUT_WINDOW_SHADOW_SIZE = 16;
const CHAT_INPUT_WINDOW_MAX_PENDING_HEIGHT = 360;
const CHAT_INPUT_WINDOW_MIN_CONFIRMATION_HEIGHT = 112;
const CHAT_INPUT_WINDOW_CONTEXT_PICKER_TRANSITION_DELAY = 100;
Expand Down Expand Up @@ -684,14 +688,18 @@ export class ChatInputWindowService extends Disposable implements IChatInputWind
return;
}
lastContentHeight = contentHeight;
// Grow the window by the shadow gutter on all sides so the surface keeps
// its content size while the CSS shadow renders into the transparent band.
const windowWidth = width + 2 * CHAT_INPUT_WINDOW_SHADOW_SIZE;
const windowHeight = contentHeight + 2 * CHAT_INPUT_WINDOW_SHADOW_SIZE;
if (!didInitialPosition) {
didInitialPosition = true;
const initialBounds = this._positionedBounds(width, contentHeight);
const initialBounds = this._positionedBounds(windowWidth, windowHeight);
currentPosition = { x: initialBounds.x, y: initialBounds.y };
} else if (!applyingBounds) {
currentPosition = { x: win.screenX, y: win.screenY };
}
pendingBounds = { ...currentPosition, width, height: contentHeight };
pendingBounds = { ...currentPosition, width: windowWidth, height: windowHeight };
void applyPendingBounds();
};
this._fitWindowToContent = fitWindowToInput;
Expand Down Expand Up @@ -1614,7 +1622,10 @@ export class ChatInputWindowService extends Disposable implements IChatInputWind
}

private _defaultBounds(): IRectangle {
return this._positionedBounds(this._defaultWidth(), CHAT_INPUT_WINDOW_DEFAULT_HEIGHT);
return this._positionedBounds(
this._defaultWidth() + 2 * CHAT_INPUT_WINDOW_SHADOW_SIZE,
CHAT_INPUT_WINDOW_DEFAULT_HEIGHT + 2 * CHAT_INPUT_WINDOW_SHADOW_SIZE
);
}

private _positionedBounds(width: number, height: number): IRectangle {
Expand Down
9 changes: 7 additions & 2 deletions src/vs/workbench/contrib/chat/browser/chatInputWindow/media/chatInputWindow.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,16 @@
--omni-rail: 20px;
--omni-icon-column: 16px;
--omni-row-gap: 8px;
/* Transparent gutter reserved so the window shadow can render without being
clipped by the frameless window bounds. Keep in sync with
CHAT_INPUT_WINDOW_SHADOW_SIZE in chatInputWindowService.ts. */
--omni-window-shadow-size: 16px;

box-sizing: border-box;
height: calc(100% - var(--vscode-strokeThickness) - var(--vscode-strokeThickness)) !important;
margin: var(--vscode-strokeThickness);
height: calc(100% - var(--omni-window-shadow-size) - var(--omni-window-shadow-size)) !important;
margin: var(--omni-window-shadow-size);
border-radius: var(--vscode-cornerRadius-xLarge);
box-shadow: 0 3px 10px 0 var(--vscode-widget-shadow, rgba(0, 0, 0, 0.36));
overflow: hidden;
}

Expand Down