Skip to content

sessions: streamline editor title actions - #331945

Merged
Sandeep Somavarapu (sandy081) merged 19 commits into
mainfrom
agents/responsive-diff-toggle-overflow-menu
Aug 22, 2026
Merged

sessions: streamline editor title actions#331945
Sandeep Somavarapu (sandy081) merged 19 commits into
mainfrom
agents/responsive-diff-toggle-overflow-menu

Conversation

@sandy081

Copy link
Copy Markdown
Member

Summary

  • move Sessions diff, view-mode, code-review, attachment, and extension editor actions into the editor title area while keeping only Toggle Details in the group header
  • expose the shared responsive diff preference as an Always Show Inline Diff overflow toggle for Session Changes and text diff editors, with collapse/expand actions alongside it
  • align single- and multi-tab Add Tab placement, separator visibility and spacing, hover sizing, accessibility help, and focused menu/fixture coverage

The behavior remains scoped to the Agents Window; the normal workbench does not configure these Sessions menus.

Validation

  • npm run compile
  • npm run hygiene
  • focused Changes, code review, editor title bridge, layout, Add Tab, and workbench tests
  • stable single-tab component fixture with computed spacing and hover-size validation

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 21, 2026 11:44
@sandy081 Sandeep Somavarapu (sandy081) added this to the 1.135.0 milestone Aug 21, 2026
@vs-code-engineering

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Benjamin Christopher Simmonds (@benibenj)

Matched files:

  • src/vs/sessions/browser/parts/media/editorPart.css
  • src/vs/sessions/browser/parts/singlePaneEditorPart.ts
  • src/vs/workbench/browser/parts/editor/editorTabsControl.ts
  • src/vs/workbench/browser/parts/editor/multiEditorTabsControl.ts
  • src/vs/workbench/browser/parts/editor/singleEditorTabsControl.ts

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 1be3e735 Current: 40ed5471

Changed (20)

sessions/changes/agentsDiffEditor/CompactDiffWithFeedback/Dark
Before After
before after
sessions/changes/agentsDiffEditor/CompactDiffWithFeedback/Light
Before After
before after
sessions/changes/agentsDiffEditor/CompactDiffWithSubmitOverlay/Dark
Before After
before after
sessions/changes/agentsDiffEditor/CompactDiffWithSubmitOverlay/Light
Before After
before after
sessions/editorHeader/editorHeader/FullHeader/Dark
Before After
before after
sessions/editorHeader/editorHeader/FullHeader/Light
Before After
before after
sessions/editorHeader/editorHeader/BreadcrumbsAndAction/Dark
Before After
before after
sessions/editorHeader/editorHeader/BreadcrumbsAndAction/Light
Before After
before after
sessions/editorHeader/editorHeader/BreadcrumbsAndSecondaryAction/Dark
Before After
before after
sessions/editorHeader/editorHeader/BreadcrumbsAndSecondaryAction/Light
Before After
before after
sessions/editorHeader/editorHeader/BreadcrumbsOnly/Dark
Before After
before after
sessions/editorHeader/editorHeader/BreadcrumbsOnly/Light
Before After
before after
sessions/editorHeader/editorHeader/PrimaryActionOnly/Dark
Before After
before after
sessions/editorHeader/editorHeader/PrimaryActionOnly/Light
Before After
before after
sessions/editorHeader/editorHeader/SecondaryActionOnly/Dark
Before After
before after
sessions/editorHeader/editorHeader/SecondaryActionOnly/Light
Before After
before after
sessions/editorHeader/editorHeader/LayoutActionsOnly/Dark
Before After
before after
sessions/editorHeader/editorHeader/LayoutActionsOnly/Light
Before After
before after
sessions/editorHeader/editorHeader/SingleTabFullHeader/Dark
Before After
before after
sessions/editorHeader/editorHeader/SingleTabFullHeader/Light
Before After
before after

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Moves Sessions-specific actions into editor title menus and aligns Add Tab presentation.

Changes:

  • Relocates diff, review, attachment, view-mode, and extension actions.
  • Adds the shared inline-diff toggle and accessibility guidance.
  • Aligns Add Tab layout, separators, styling, fixtures, and tests.
Show a summary per file
File Description
singleEditorTabsControl.ts Repositions single-tab Add Tab control.
multiEditorTabsControl.ts Simplifies editor toolbar creation.
editorTabsControl.ts Consolidates separator handling.
workbench.test.ts Updates header-menu expectations.
layoutActions.test.ts Verifies attachment action placement.
editorTitleMenuBridge.test.ts Updates extension-action bridge tests.
editorHeader.fixture.ts Loads Sessions editor-part styling.
editor.contribution.ts Moves attachment and extension actions.
codeReviewService.test.ts Tests title-bar code-review contribution.
codeReview.contributions.ts Moves Run Code Review to editor title.
changesViewActions.test.ts Expands title-menu and accessibility tests.
sessionsChangesAccessibilityHelp.ts Documents the inline-diff toggle.
changesViewActions.ts Moves diff and view actions to editor title.
singlePaneEditorPart.ts Removes the secondary header menu.
editorPart.css Aligns title actions and Add Tab styling.
menus.ts Removes the obsolete secondary-header menu.

Review details

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 16/16 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment thread src/vs/sessions/contrib/changes/browser/sessionsChangesAccessibilityHelp.ts Outdated
Comment thread src/vs/sessions/contrib/codeReview/browser/codeReview.contributions.ts Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
auto-merge was automatically disabled August 21, 2026 14:57

Pull request was closed

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The fix is minimal and correct.

@sandy081
Sandeep Somavarapu (sandy081) merged commit 0984c92 into main Aug 22, 2026
27 checks passed
@sandy081
Sandeep Somavarapu (sandy081) deleted the agents/responsive-diff-toggle-overflow-menu branch August 22, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants