sessions: sort tunnel picker by name - #333463
Merged
Dmitriy Vasyura (dmitrivMS) merged 3 commits intoAug 31, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
August 31, 2026 07:02
View session
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
August 31, 2026 07:03
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/vs/sessions/contrib/providers/remoteAgentHost/browser/remoteAgentHostActions.ts — This helper is only used within this module, so exporting it unnecessarily expands the module's… |
What changed in this PR
Sorts discovered Dev Tunnels by display name without mutating discovery results.
Changes:
- Adds a copy-and-sort helper.
- Applies sorting before creating tunnel picker items.
| File | Description |
|---|---|
remoteAgentHostActions.ts |
Sorts Dev Tunnel picker entries alphabetically. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dirk Bäumer (dbaeumer)
approved these changes
Aug 31, 2026
Martin Aeschlimann (aeschli)
approved these changes
Aug 31, 2026
Dmitriy Vasyura (dmitrivMS)
deleted the
agents/fix-tunnel-picker-sorting
branch
August 31, 2026 08:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tunnel picker previously preserved the arbitrary order returned by tunnel discovery. Sort a copy of the discovered tunnels by display name before creating the picker items, while leaving the original discovery result unchanged.