Skip to content

sessions: sort tunnel picker by name #333463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dmitriy Vasyura (dmitrivMS) merged 3 commits into from
Aug 31, 2026
Merged

sessions: sort tunnel picker by name #333463

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfa5c25
sessions: sort tunnel picker by name
dmitrivMS Aug 31, 2026
9eed071
Merge branch 'main' into agents/fix-tunnel-picker-sorting
dmitrivMS Aug 31, 2026
d51787d
sessions: keep tunnel sorter internal
dmitrivMS Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/vs/sessions/contrib/providers/remoteAgentHost/browser/remoteAgentHostActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -841,6 +841,10 @@ interface ITunnelPickItem extends IQuickPickItem {
readonly tunnel: ITunnelInfo;
}

export function sortTunnelsByName(tunnels: readonly ITunnelInfo[]): ITunnelInfo[] {
Comment thread
dmitrivMS marked this conversation as resolved.
Outdated
return [...tunnels].sort((a, b) => a.name.localeCompare(b.name));
}

async function promptToConnectViaTunnel(
accessor: ServicesAccessor,
options: { showBackButton?: boolean } = {},
Expand Down Expand Up @@ -901,7 +905,7 @@ async function promptToConnectViaTunnel(
tooltip: localize('tunnelDeleteTooltip', "Delete Dev Tunnel"),
};
const isHostedTunnel = (tunnel: ITunnelInfo): boolean => isTunnelHosted(tunnelHostService.sharingInfo, tunnel);
const toTunnelPickItems = (tunnelInfos: readonly ITunnelInfo[]): ITunnelPickItem[] => tunnelInfos
const toTunnelPickItems = (tunnelInfos: readonly ITunnelInfo[]): ITunnelPickItem[] => sortTunnelsByName(tunnelInfos)
.filter(tunnel => !isHostedTunnel(tunnel))
.map(tunnel => ({
label: tunnel.name,
Expand Down
Loading