build(npm): add --json output option to check-allow-scripts - #334137
Open
Deniz Güney Yıldırım (denizguney) wants to merge 2 commits into
Open
build(npm): add --json output option to check-allow-scripts#334137Deniz Güney Yıldırım (denizguney) wants to merge 2 commits into
Deniz Güney Yıldırım (denizguney) wants to merge 2 commits into
Conversation
Add support for the --json flag in check-allow-scripts.ts to output pending install script check results in JSON format for automated tooling and CI pipelines.
Copilot started reviewing on behalf of
Deniz Güney Yıldırım (denizguney)
September 2, 2026 22:27
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Removing the main() invocation prevents the script from executing.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds machine-readable --json output for pending npm install-script approvals.
Changes:
- Detects the
--jsonargument. - Serializes pending-script results and preserves failure exit codes.
File summaries
| File | Description |
|---|---|
build/npm/check-allow-scripts.ts |
Adds JSON output support. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Restore the main() entry-point call to ensure check-allow-scripts.ts executes correctly when run from the build pipeline or with the --json flag, addressing Copilot feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the
--jsonflag inbuild/npm/check-allow-scripts.tsto output pending install script check results in JSON format for automated tooling and CI pipelines.Related to #334134