Skip to content

build(npm): add --json output option to check-allow-scripts #334137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Deniz Güney Yıldırım (denizguney) wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −8
Open

build(npm): add --json output option to check-allow-scripts #334137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3b98ae
build(npm): add --json output option to check-allow-scripts
denizguney Sep 2, 2026
9a49a92
fix(build): restore main() invocation in check-allow-scripts.ts
denizguney Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions build/npm/check-allow-scripts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,13 @@ function checkDirectory(directory: string): CheckResult {
}

function main(): void {
const args = process.argv.slice(2);
const jsonOutput = args.includes('--json');

const packageDirectories = dirs
.map(dir => path.join(root, dir))
.filter(directory => existsSync(path.join(directory, 'package.json')));

const results: CheckResult[] = [];
for (const directory of packageDirectories) {
const result = checkDirectory(directory);
Expand All @@ -72,20 +76,21 @@ function main(): void {
}
}

if (jsonOutput) {
console.log(JSON.stringify(results, null, 2));
if (results.length > 0) {
process.exitCode = 1;
}
return;
}

if (results.length === 0) {
console.log(`Checked ${packageDirectories.length} package.json files: all install scripts are covered by allowScripts.`);
return;
}

console.error(`Found unreviewed install scripts in ${results.length} package.json files:`);
for (const result of results) {
console.error(`\n${path.relative(root, result.directory) || '.'}/package.json`);
for (const pending of result.pending) {
console.error(` - ${pending.package} (${pending.scripts})`);
}
}
console.error('\nRun `npm approve-scripts <pkg>` in each directory to review the pending install scripts.');
process.exitCode = 1;
}

main();
main();