Skip to content

Build with @github/copilot canary version - #334649

Merged
roblourens merged 3 commits into
release/1.137from
roblou/agents/product-copilot-runtime-release-1.137
Sep 5, 2026
Merged

Build with @github/copilot canary version#334649
roblourens merged 3 commits into
release/1.137from
roblou/agents/product-copilot-runtime-release-1.137

Conversation

@roblourens

@roblourens roblourens commented Sep 4, 2026

Copy link
Copy Markdown
Member

Summary

  • keep OSS builds on the public @github/copilot and @github/copilot-sdk versions
  • keep product builds on the same SDK as OSS
  • check in 1.0.84-canary.67.g6496fad.unsigned as the default product @github/copilot runtime version
  • extend the existing authenticated Azure override to support runtime-only changes
  • accept the runtime's policyHelper managed-settings diagnostics source

Implementation

The existing VSCODE_CLI_CANARY_VERSION parameter remains the product-build override mechanism, but its checked-in default is now the desired runtime canary. VSCODE_SDK_CANARY_VERSION stays none, so product builds retain the SDK from the OSS manifest. The shared pre-cache step now runs when either override is present and refreshes only the dependency that changed.

Validation

  • cd build && npm run typecheck
  • npm run typecheck-client
  • npm run hygiene
  • authenticated CLI-only override exercised in root and remote manifests using the prior published runtime canary
  • read-only subagent review found no significant issues

The requested 1.0.84-canary.67.g6496fad.unsigned package is not yet visible on the private feed, so an Azure product build with that exact runtime cannot succeed until it is published.

Ported to release/1.137; main counterpart is #334648.

(Written by Copilot)

Keep OSS builds on the public Copilot dependencies while product builds default to @github/copilot runtime 1.0.84-canary.66.g9267bf0.unsigned from the private feed. Extend the existing override path to support changing only the runtime.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 4, 2026 22:44
Keep the existing sdk-canary build tag emission scoped to latest-canary resolution while adding runtime-only overrides.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Both pipelines default to an unpublished package version, causing normal product builds to fail.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: None

What changed in this PR

Overrides the Copilot runtime in product builds while retaining OSS SDK versions and recognizing the runtime’s new managed-settings source.

Changes:

  • Enables independent SDK/runtime overrides in Azure pipelines.
  • Defaults product builds to Copilot runtime 1.0.84-canary.66.g9267bf0.unsigned.
  • Accepts policyHelper in managed-settings diagnostics.
File Description
build/​azure-pipelines/​product-build.yml Sets the product runtime default.
build/​azure-pipelines/​product-build-ado-ci.yml Mirrors the runtime default for ADO CI.
build/​azure-pipelines/​common/​apply-sdk-canary.yml Runs authenticated overrides for either dependency.
build/​azure-pipelines/​common/​apply-sdk-canary-override.ts Supports runtime-only overrides.
src/​vs/​platform/​agentHost/​common/​agent.ts Adds the policyHelper source.
src/​vs/​platform/​agentHost/​test/​node/​e2e/​suites/​managementExtensionsSuite.ts Accepts the source in E2E validation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@roblourens roblourens changed the title build: override product Copilot runtime Build with @github/copilot canary version Sep 4, 2026
Set the checked-in product runtime override to 1.0.84-canary.67.g6496fad.unsigned.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@roblourens
roblourens marked this pull request as ready for review September 5, 2026 01:45
@roblourens
roblourens merged commit 2f5a733 into release/1.137 Sep 5, 2026
40 checks passed
@roblourens
roblourens deleted the roblou/agents/product-copilot-runtime-release-1.137 branch September 5, 2026 01:45
@vs-code-engineering

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Ladislau Szomoru (@lszomoru)

Matched files:

  • build/azure-pipelines/common/apply-sdk-canary-override.ts
  • build/azure-pipelines/common/apply-sdk-canary.yml
  • build/azure-pipelines/product-build-ado-ci.yml
  • build/azure-pipelines/product-build.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants