More model picker improvements - #334674
Merged
Merged
Conversation
Logan Ramos (lramos15)
commented
Sep 5, 2026
Logan Ramos (lramos15)
commented
Member
- Cleanup focus issues
- Cleanup model picker card
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The cross-cutting focus, pointer, accessibility, zoom, and popup-layout behavior warrants final human UI validation.
Review tier: Balanced
Findings: None
What changed in this PR
Improves model-picker cards, focus handling, persistent previews, Auto-tier interaction, and popup sizing.
Changes:
- Adds persistent, keyboard-accessible model detail previews.
- Keeps Auto tiers visible and safely sequences configuration changes.
- Expands UI, accessibility, layout, and fixture coverage.
| File | Description |
|---|---|
tabbedModelPicker.fixture.ts |
Adds anchored and expanded visual scenarios. |
modelPickerAutoRow.test.ts |
Tests tier interaction, focus, failures, and races. |
chatAccessibilityHelp.test.ts |
Tests updated model-picker guidance. |
modelPickerTabbedWidget.ts |
Enables persistent model-card previews. |
modelPickerAutoRow.ts |
Keeps tiers available and sequences updates. |
modelPicker.css |
Refines inactive tiers and focus styling. |
chatAccessibilityHelp.ts |
Documents picker keyboard behavior. |
tabbedActionListWidget.test.ts |
Tests initial previews, focus, and footer sizing. |
actionList.test.ts |
Tests persistent preview behavior and positioning. |
tabbedActionListWidget.ts |
Preserves popup size and focus during updates. |
actionList.ts |
Implements persistent hover panels and positioning. |
radio.test.ts |
Adds comprehensive radio interaction tests. |
radio.ts |
Adds activation events and focus APIs. |
radio.css |
Stabilizes segmented-radio sizing and focus visuals. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: Changed (46)
|
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/Picker/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerWithAddedModels/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerWithAddedModels/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerAddedModelsTab/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerAddedModelsTab/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerWithManyProviders/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerWithManyProviders/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerAddedModelsPinned/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerAddedModelsPinned/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerWithAutoSelected/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerWithAutoSelected/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerAutoOnlyPlan/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerAutoOnlyPlan/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerRelayedByHost/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerRelayedByHost/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerLockedModels/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerLockedModels/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerLockedModelsBusiness/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerLockedModelsBusiness/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerBadges/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerBadges/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerConfiguredModels/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerConfiguredModels/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerSearch/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerSearch/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerWithCard/Dark
| Before | After |
|---|---|
 |
|
chat/input/tabbedModelPicker/PickerWithCard/Light
| Before | After |
|---|---|
 |
|
chat/input/tabbedModelPicker/PickerWelcome/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerWelcome/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/CardStandardContext/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/CardStandardContext/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/CardPricingExpanded/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/CardPricingExpanded/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerSpeedVariants/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerSpeedVariants/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerSpeedVariantsFastSelected/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/PickerSpeedVariantsFastSelected/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/CardExtendedContext/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/CardExtendedContext/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/CardManyEffortValues/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/CardManyEffortValues/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/AutoRowOff/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/AutoRowOff/Light
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/AutoRowOn/Dark
| Before | After |
|---|---|
 |
 |
chat/input/tabbedModelPicker/AutoRowOn/Light
| Before | After |
|---|---|
 |
 |
3 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
Added (16)
chat/input/tabbedModelPicker/PickerAnchored/Dark
chat/input/tabbedModelPicker/PickerAnchored/Light
chat/input/tabbedModelPicker/PickerAnchored/DarkHighContrast
chat/input/tabbedModelPicker/PickerAnchoredRight/Dark
chat/input/tabbedModelPicker/PickerAnchoredRight/Light
chat/input/tabbedModelPicker/PickerAnchoredRight/DarkHighContrast
chat/input/tabbedModelPicker/PickerAnchoredWithCollapsedModels/Dark
chat/input/tabbedModelPicker/PickerAnchoredWithCollapsedModels/Light
chat/input/tabbedModelPicker/PickerAnchoredWithCollapsedModels/DarkHighContrast
chat/input/tabbedModelPicker/PickerAnchoredAutoSelected/Dark
chat/input/tabbedModelPicker/PickerAnchoredAutoSelected/Light
chat/input/tabbedModelPicker/PickerAddedModelSelected/Dark
chat/input/tabbedModelPicker/PickerAddedModelSelected/Light
chat/input/tabbedModelPicker/CardPricingExpanded/DarkHighContrast
chat/input/tabbedModelPicker/CardManyEffortValues/DarkHighContrast
chat/input/tabbedModelPicker/AutoRowOn/DarkHighContrast
Use the Sessions-owned workspace picker setting in the provider and its tests to fix CI compilation and platform test failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
TylerLeonhardt
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.