nes: Recognize eagerness option in PatchBased02Unified - #334830
Merged
Ulugbek Abdullaev (ulugbekna) merged 1 commit intoSep 7, 2026
Conversation
Recognize unified strategy eagerness prompts Treat the optimized PatchBased02 unified strategy as eagerness-aware when a model supplies an eagerness prompt, while preserving non-eagerness behavior for unrelated strategies. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ulugbek Abdullaev (ulugbekna)
enabled auto-merge (squash)
September 6, 2026 21:30
Copilot started reviewing on behalf of
Ulugbek Abdullaev (ulugbekna)
September 6, 2026 21:30
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation is consistent with existing patch-based strategies and is adequately tested.
Review tier: Balanced
Findings: None
What changed in this PR
Extends eagerness-prompt detection to the unified PatchBased02 strategy.
Changes:
- Recognizes
PatchBased02Unifiedwhen eagerness prompting is configured. - Adds positive, negative, and unrelated-strategy tests.
| File | Description |
|---|---|
extensions/copilot/src/platform/inlineEdits/common/dataTypes/xtabPromptOptions.ts |
Adds unified strategy recognition. |
extensions/copilot/src/platform/inlineEdits/test/common/xtabPromptOptions.spec.ts |
Tests the updated detection behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Dmitriy Vasyura (dmitrivMS)
approved these changes
Sep 6, 2026
Benjamin Christopher Simmonds (benibenj)
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.