sessions: Show status indicators in collapsed sections - #335533
Merged
Benjamin Christopher Simmonds (benibenj) merged 9 commits intoSep 11, 2026
Merged
Conversation
Add a default-on experiment-controlled setting. Derive unread state from section membership, preserving hover and keyboard-focus chevrons. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Benjamin Christopher Simmonds (benibenj)
September 10, 2026 18:54
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The ARIA label misrepresents unread counts, and the setting description omits affected section types.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
 |
src/vs/sessions/contrib/sessions/browser/views/sessionsList.ts — Announce the actual unread count |
 |
src/vs/sessions/contrib/sessions/browser/sessions.contribution.ts — Describe all affected section types |
What changed in this PR
Adds unread indicators to collapsed Sessions list sections while preserving existing interaction and accessibility behavior.
Changes:
- Derives section unread state from filtered/grouped members.
- Adds a preview setting with automatic experiment control.
- Adds unit, fixture, accessibility, and multi-theme Playwright coverage.
| File | Description |
|---|---|
sessionsList.ts |
Implements reactive unread icons and ARIA labels. |
sessions.contribution.ts |
Registers the new setting. |
sessionsList.test.ts |
Tests grouping, filtering, updates, and precedence. |
sessionsListTestUtils.ts |
Adds mutable read-state test support. |
sessions.contribution.test.ts |
Verifies setting registration. |
sessionsList.fixture.ts |
Adds enabled and disabled visual fixtures. |
sessionsListTwistie.spec.ts |
Tests themes, hover, focus, and expansion. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: 3 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details. Added (24)
|
Prioritize needs-input sessions over unread indicators using the existing status widget, preserving section ownership, hover chevrons, and reduced-motion behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Benjamin Christopher Simmonds (benibenj)
changed the title
Prioritize needs-input, then CI failures in sessions that are not in progress, then unread state. Always exclude archived sessions and retain automatic experiment control. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Benjamin Christopher Simmonds (benibenj)
changed the title
Describe unread containment without implying an unread count, and clarify that the setting covers collapsed sections generally. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Benjamin Christopher Simmonds (benibenj)
marked this pull request as ready for review
September 10, 2026 21:33
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Ulugbek Abdullaev (@ulugbekna)Matched files:
|
Preserve both collapsed-section indicator coverage and upstream hover/diff-stat tests when resolving the session-list import conflicts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Vritant Bhardwaj (vritant24)
previously approved these changes
Sep 10, 2026
Capture the registered schema before configuration tests reset the shared registry, matching the existing Automations contribution test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Record the 24 CI-rendered indicator fixtures, including the default-disabled variants, across all four themes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sandeep Somavarapu (sandy081)
previously approved these changes
Sep 11, 2026
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge
September 11, 2026 11:09
Preserve upstream empty-group coverage alongside the collapsed-section status tests and screenshot baselines. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dirk Bäumer (dbaeumer)
previously approved these changes
Sep 11, 2026
Keep the new screenshot fixtures and browser tests without requiring committed baseline updates for their visual differences. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Henning Dieterichs (hediet)
approved these changes
Sep 11, 2026
Benjamin Christopher Simmonds (benibenj)
merged commit Sep 11, 2026
b2eb7c1
into
main
33 checks passed
Benjamin Christopher Simmonds (benibenj)
deleted the
benibenj/agents/unread-icon-collapsed-groups
branch
September 11, 2026 13:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sessions.list.showUnreadInCollapsedSections, disabled by default with automatic experiment control.Validation