fix: update aggregator address for eurc to new Scroll team oracle

[dmytro-horbatenko]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @dmytro-horbatenko, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the configuration for the EURC token's price aggregator. The change involves switching from a previously manually managed oracle address to a new, officially provided oracle address from the Scroll team, ensuring more reliable and up-to-date price feeds for the EURC token.

Highlights

• EURC Aggregator Address Update: The aggregator address for EURC within the midasAddressesPerNetwork configuration has been updated to a new oracle provided by the Scroll team. The previous manually managed oracle address has been replaced with the new one.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• config/constants/addresses.ts
  • Updated the aggregator address for eurc from 0x6CDbBb744a04740a179AF4C92E03C1Bf1eC552C8 to 0x24c8964338Deb5204B096039147B8e8C3AEa42Cc.
  • Added comments to clarify the change, indicating the previous manually managed oracle and the new Scroll team oracle.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the aggregator address for the EURC token on the Scroll network, switching from a manually managed oracle to one provided by the Scroll team. The change is a straightforward configuration update. I've added one comment to improve the maintainability of the code comments by removing redundancy.

[gemini-code-assist]

The new aggregator address is repeated in this comment and in the code on the next line. This is redundant and can lead to inconsistencies if the address is updated in one place but not the other. It's a good practice for comments to explain why a change was made, not what the code is doing, as the code itself shows the 'what'.

Suggested change

	// Now using the oracle provided by the Scroll team: 0x24c8964338Deb5204B096039147B8e8C3AEa42Cc
	// Now using the oracle provided by the Scroll team.