Skip to content

fix: update aggregator address for eurc to new Scroll team oracle #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmytro-horbatenko wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: update aggregator address for eurc to new Scroll team oracle #186

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20bd73b
fix: update aggregator address for eurc to new Scroll team oracle
dmytro-horbatenko Feb 17, 2026
9f7e9cd
Merge branch 'main' into fix/eurc-on-scroll-aggregator
dmytro-horbatenko Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion config/constants/addresses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1228,7 +1228,9 @@ export const midasAddressesPerNetwork: ConfigPerNetwork<
},
eurc: {
token: '0x174d1A887e971f7d0fe5C68b328c30e0ED743160',
aggregator: '0x6CDbBb744a04740a179AF4C92E03C1Bf1eC552C8',
// Previously used: 0x6CDbBb744a04740a179AF4C92E03C1Bf1eC552C8 (manually managed oracle)
// Now using the oracle provided by the Scroll team: 0x24c8964338Deb5204B096039147B8e8C3AEa42Cc
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new aggregator address is repeated in this comment and in the code on the next line. This is redundant and can lead to inconsistencies if the address is updated in one place but not the other. It's a good practice for comments to explain why a change was made, not what the code is doing, as the code itself shows the 'what'.

Suggested change
// Now using the oracle provided by the Scroll team: 0x24c8964338Deb5204B096039147B8e8C3AEa42Cc
// Now using the oracle provided by the Scroll team.

aggregator: '0x24c8964338Deb5204B096039147B8e8C3AEa42Cc',
dataFeed: '0x0c1E886A0ceBF805f66223333e204d39BE6612De',
},
},
Expand Down
Loading