fix: builds missing wheels #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesgranger
approved these changes
Jan 7, 2026
Owner
milesgranger
left a comment
milesgranger
left a comment
There was a problem hiding this comment.
Stupendous, thank you! :)
milesgranger
reviewed
Jan 7, 2026
Comment on lines
+263
to
+270
| args: --out dist | ||
| - name: Publish to PyPi | ||
| env: | ||
| TWINE_USERNAME: __token__ | ||
| TWINE_PASSWORD: ${{ secrets.TWINE_TOKEN }} | ||
| run: | | ||
| pip install --upgrade wheel pip setuptools twine | ||
| twine upload --skip-existing * | ||
| twine upload --skip-existing dist/* |
Owner
There was a problem hiding this comment.
My fault, I missed this - the v0.4.2-post1 release only updated sdist since this should have been twine upload --skip-existing dist/* * or alternatively like I did in the following commit output the sdist to the current directory and remove the dist/*, just keeping the *.
Owner
There was a problem hiding this comment.
nvm, that was also unhappy since other non pypi files were there - now just kept this and put wheels in their own directory as well. :)
This was referenced Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing
needsentries I think are the culprit for the missing wheels in the 0.4.2 release and the extra sdist step should make sure there's an sdist included in the release.🤞