Skip to content

fix: builds missing wheels #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milesgranger merged 1 commit into from
Jan 7, 2026
Merged

fix: builds missing wheels #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,19 +246,25 @@ jobs:
name: Release
runs-on: ubuntu-latest
if: startsWith(github.ref, 'refs/tags/')
needs: [macos, windows, linux]
needs: [macos, windows, linux, linux-cross, pypy-linux, pypy-macos]
steps:
- uses: actions/checkout@v5
- uses: actions/download-artifact@v5
with:
pattern: wheels-*
merge-multiple: true
- uses: actions/setup-python@v6
with:
python-version: "3.13"
- name: Build sdist
uses: PyO3/maturin-action@v1
with:
command: sdist
args: --out dist
- name: Publish to PyPi
env:
TWINE_USERNAME: __token__
TWINE_PASSWORD: ${{ secrets.TWINE_TOKEN }}
run: |
pip install --upgrade wheel pip setuptools twine
twine upload --skip-existing *
twine upload --skip-existing dist/*
Comment on lines +263 to +270
Copy link
Owner

@milesgranger milesgranger Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault, I missed this - the v0.4.2-post1 release only updated sdist since this should have been twine upload --skip-existing dist/* * or alternatively like I did in the following commit output the sdist to the current directory and remove the dist/*, just keeping the *.

Copy link
Owner

@milesgranger milesgranger Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, that was also unhappy since other non pypi files were there - now just kept this and put wheels in their own directory as well. :)