Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue of loading partition hanging #422

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xwjdsh
Copy link

@xwjdsh xwjdsh commented Mar 16, 2023

The program gets stuck here when I try to load a partition in sync mode.

	err = s.client.LoadPartitions(
		ctx,                     // ctx
		collectionName,          // CollectionName
		[]string{partitionName}, // PartitionNames
		false,                   // async
	)
	if err != nil {
		return nil, err
	}

Then I noticed that the InMemoryPercentages in ShowPartitions response has been deprecated, and I've also used curl http://localhost:9091/api/v1/partitions to confirm that it's not responding. I used c.GetLoadingProgress instead of c.ShowPartitions, and the problem was solved.

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xwjdsh
To complete the pull request process, please assign sunby after the PR has been reviewed.
You can assign the PR to them by writing /assign @sunby in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link

Welcome @xwjdsh! It looks like this is your first PR to milvus-io/milvus-sdk-go 🎉

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Mar 16, 2023
@bigsheeper
Copy link
Contributor

Hi @xwjdsh , thank you for your contribution to Milvus. Could you please help modify the LoadCollection as well, like #424. Then I could close my duplicated pr. Have a nice day!

@congqixia
Copy link
Contributor

Hi @xwjdsh thanks for you PR!
It looks like the DCO check failed. Could you please fix that?

@xwjdsh
Copy link
Author

xwjdsh commented Mar 17, 2023

@bigsheeper OK, I'll update this. updated.

@xwjdsh xwjdsh force-pushed the feat/fix-load-partition-pending branch from 3d43893 to 40d8051 Compare March 17, 2023 06:47
@xwjdsh
Copy link
Author

xwjdsh commented Mar 17, 2023

@congqixia It's OK now.

@xwjdsh xwjdsh force-pushed the feat/fix-load-partition-pending branch 2 times, most recently from d6040af to 35b6367 Compare March 17, 2023 09:33
…the ShowPartition api response

Fix load collection hang issue

Signed-off-by: Wen Sun <[email protected]>
@xwjdsh xwjdsh force-pushed the feat/fix-load-partition-pending branch from 35b6367 to 8b32816 Compare March 17, 2023 11:08
Signed-off-by: Wen Sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants