Skip to content
This repository was archived by the owner on Jan 9, 2025. It is now read-only.

Fix all tests for PHP 7.x #189

Closed
wants to merge 32 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
d778df8
Fixed all tests
pietrinoatzenimfm Mar 5, 2019
9ac0499
Updated travis configuration
pietrinoatzenimfm Mar 5, 2019
4787172
Removed phpunit from composer
pietrinoatzenimfm Mar 5, 2019
6bdf7b2
Refactored Server to remove deprecated ProcessBuilder
pietrinoatzenimfm Mar 5, 2019
c92a773
Fixed process arguments
pietrinoatzenimfm Mar 5, 2019
3f85c91
Removed process call for PHP 5.4 compatibility
pietrinoatzenimfm Mar 5, 2019
874eb06
Reverted code formatting changes
pietrinoatzenimfm Mar 5, 2019
04bfdfe
Added base test case
pietrinoatzenimfm Mar 5, 2019
c90153c
Removed unwanted files
pietrinoatzenimfm Mar 5, 2019
9ece31d
Fixed test case for PHPUnit 4+
pietrinoatzenimfm Mar 5, 2019
49910d8
Fixing env for PHP 5.3
pietrinoatzenimfm Mar 5, 2019
4679d73
Showing PHPUnit version
pietrinoatzenimfm Mar 5, 2019
e30a95a
Setting a fixed version of PHPUnit for PHP 7.2 and 7.3
pietrinoatzenimfm Mar 5, 2019
c02a209
Fixing Process building for PHP 5.4
pietrinoatzenimfm Mar 5, 2019
4f8fe1e
Using foreach for env variables
pietrinoatzenimfm Mar 5, 2019
9e912bd
Added PHPUnit versions for PHP 5.5, 7.2 and 7.3
pietrinoatzenimfm Mar 5, 2019
d50fedd
Fixing the phpunit command
pietrinoatzenimfm Mar 5, 2019
be39387
Removed printing the phpunit version
pietrinoatzenimfm Mar 5, 2019
3385fc0
Fixing node version for PHP 5.3
pietrinoatzenimfm Mar 5, 2019
4f8fca7
Fixed composer to set a specific version of symfony/phpunit-bridge fo…
pietrinoatzenimfm Mar 5, 2019
c2709c9
Fixing PHPUnit version for PHP 5.3 and 5.5
nubee Mar 5, 2019
d3e8bb8
Removed Node version for PHP 5.3
nubee Mar 5, 2019
6a2ecec
Removed Node version for PHP 5.3
nubee Mar 5, 2019
15a5499
Added Node version for PHP 5.3
nubee Mar 5, 2019
f9c3331
Added symfony/phpunit-bridge only for PHP 5.3
nubee Mar 6, 2019
657cdb4
Testing PHP 5.3
nubee Mar 6, 2019
320413a
Testing PHP 5.3
nubee Mar 6, 2019
933d56a
Testing PHP 5.3
nubee Mar 6, 2019
13ee097
Fixed PHP 5.3 and testing latest node and zombie
nubee Mar 6, 2019
0a5bd6f
Testing PHP 7.3 without running mink-test-server with PHP 5.6
nubee Mar 6, 2019
beaabcc
Testing PHP 7.3 without running mink-test-server with PHP 5.6
nubee Mar 6, 2019
a13fdf2
Fixed all tests
nubee Mar 6, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@
},

"require-dev": {
"mink/driver-testsuite": "dev-master"
"mink/driver-testsuite": "dev-master",
"phpunit/phpunit": "^6.0"
},

"autoload": {
Expand Down
3 changes: 2 additions & 1 deletion tests/Custom/InstantiationTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
namespace Behat\Mink\Tests\Driver\Custom;

use Behat\Mink\Driver\ZombieDriver;
use PHPUnit\Framework\TestCase;

class InstantiationTest extends \PHPUnit_Framework_TestCase
class InstantiationTest extends TestCase
{
public function testInstantiateWithServer()
{
Expand Down
3 changes: 2 additions & 1 deletion tests/Custom/NodeJS/ServerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use Behat\Mink\Driver\NodeJS\Connection;
use Behat\Mink\Driver\NodeJS\Server as BaseServer;
use PHPUnit\Framework\TestCase;

class TestServer extends BaseServer
{
Expand Down Expand Up @@ -47,7 +48,7 @@ protected function getServerScript()
}
}

class ServerTest extends \PHPUnit_Framework_TestCase
class ServerTest extends TestCase
{
public function testCreateServerWithDefaults()
{
Expand Down