-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all tests for PHP 7.x #189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests should be run with phpunit and not simple-phpunit (because PHP 7-1 uses PHPUnit 5.7).
I'm not sure, why you thinking, that simple-phpunit
is used.
Fixing https://travis-ci.org/minkphp/MinkZombieDriver/jobs/502013256 would require locking to non-latest PHPUnit version for PHP 7.x version. To fix https://travis-ci.org/minkphp/MinkZombieDriver/jobs/502013252 you need to do use latest PHPUnit version compatible with PHP 5.5. |
…r PHP 5.3 compatibility
The https://travis-ci.org/minkphp/MinkZombieDriver/jobs/502148600 build of PHP 5.3 has failed due incorrect NODEJS path. |
@beoboo , good job indeed. Just finish latest comments I've mentioned (about I have no idea why PHP 5.3 build fails that bad. I've tried to to run test locally using PHP 5.3.29 and Zombie 6.1.4. |
I think PHP 5.3 might be failing because the script is not able to run
(or better it exists without showing any error). I'll try removing the output redirects to debug it. |
You do create lots of commits (I guess no other way to test Travis CI) and I do get an e-mail for every of them. When you're ready for review just post a comment. |
Ready for review 😄. |
Looks good to me. @stof , what you think? |
This looks awesome, and would bring mink one step closer to be compatible with Symfony 4 (see minkphp/Mink#757). Anything I can do to help this move forward? |
Any news? |
@aik099 can we move forward on this please? Moving forward to allow using Symfony 4 is an important next step for Mink I think, since all developers that use Symfony flex that install Mink now will get an error. |
I applied this PR and raised composer requirement |
@stof Any updates on this? |
Closing in favor of #196 |
Tests should be run with phpunit and not simple-phpunit (because PHP 7-1 uses PHPUnit 5.7).