Closed
Conversation
commands are NOT binded to controller buttons
set controller bindings for open loop control
add open loop control bindings for collar
…/Robot-Code-2025 into riley/open-loop-control
…/Robot-Code-2025 into riley/open-loop-control
translation controlls are flipped on both axis for some reason.
implement sysID routines
add code and bindings for elevator sysID
ConnieJChi
reviewed
Feb 21, 2025
|
|
||
| public static final double INITIAL_POSITION = 0; | ||
| public static final double METERS_PER_ROTATION = 0.0; | ||
| public static final double METERS_PER_ROTATION = Units.Meters.convertFrom(1.751 * Math.PI/5, Units.Inches); // temp |
|
|
||
| public static JoystickVals adjustInputs(double x, double y, boolean slowmode) { | ||
| return adjustSlowmode(inputShape(x, y), slowmode); | ||
| return adjustSlowmode(inputShape(x, y), slowmode); |
There was a problem hiding this comment.
nit: remove whitespace at the end of this line :3
| new ParallelCommandGroup( | ||
| new InstantCommand(() -> {nextState = RobotState.L2_ALGAE;}), | ||
| m_ledSubsystem.runSolidPink())); | ||
| //copilotJoystick.leftTrigger().onTrue( |
There was a problem hiding this comment.
Note: We're probably going to have a lot of merge conflicts with these lines, they change frequently across all of our MRs 😬
| log.motor("elevatorsysID") | ||
| .voltage( | ||
| m_appliedVoltage.mut_replace( | ||
| m_IO.getVoltage(), Volts)) |
There was a problem hiding this comment.
It's showing that getVoltage() is undefined for m_IO :sus:. Are we sure this code works correctly?
Contributor
|
@aishahnazar Can we cherry pick the two commits that actually have to do with sys-id into a new PR. |
Contributor
Author
|
okay, just submitted a new PR [https://github.com//pull/73] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add sysID command and bindings for elevator