Update to Blockly 11 #3588

mjgallag · 2025-09-05T22:06:54Z

General items:

I have updated the relevant documentation files under docs/
My code follows the:
- Google Java style guide (for .java files)
- Google JavaScript style guide (for .js files)
ant tests passes on my machine

If your code changes how something works on the device (i.e., it affects the companion):

I branched from ucr
My pull request has ucr as the base

Further, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):

I have updated the corresponding version number in appinventor/components/src/.../common/YaVersion.java
I have updated the corresponding upgrader in appinventor/appengine/src/.../client/youngandroid/YoungAndroidFormUpgrader.java (components only)
I have updated the corresponding entries in appinventor/blocklyeditor/src/versioning.js

For all other changes:

I branched from master
My pull request has master as the base

What does this PR accomplish?

Resolves #3434, Resolves #3529, Resolves #3530, Resolves #3531, Resolves #3532

mjgallag · 2025-09-05T22:33:01Z

I just found a bug that I'll work on next. While delete count is correct (includes children too) when selecting multiple blocks only the block (and its children, if any) you right click on is deleted.

ewpatton · 2025-09-05T22:40:07Z

Is this true in master as well? In either case the issue will be somewhere in the multi select plugin.Sent from my iPhoneOn Sep 5, 2025, at 18:33, Michael Gallagher ***@***.***> wrote:mjgallag left a comment (mit-cml/appinventor-sources#3588) I just found a bug that I'll work on next. While delete count is correct (includes children too) when selecting multiple blocks only the block (and its children, if any) you right click on is deleted. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

mjgallag · 2025-09-05T22:42:43Z

@ewpatton it works in master so I either messed up the merge mit-cml/workspace-multiselect@main...mjgallag:workspace-multiselect:update-to-blockly-11 or its a Blockly 11 issue with the plugin.

mjgallag · 2025-09-06T01:57:38Z

@ewpatton its reproducible on main branch of multiselect plugin but works if I try commit before it was upgraded to Blockly 11.

mjgallag · 2025-09-06T02:26:32Z

@ewpatton ha ... now i'm not so sure about any of my statements regarding this bug ... tbd

mjgallag · 2025-09-06T21:07:10Z

Ah ha, it's a subtle bug that was introduced when the multiselect plugin was upgraded to Blockly 11. If you keep the shift key pressed when you right click the yellow borders of multiple select are lost and even though context menu has correct multiple counts it only acts on block you right clicked. If you let go of shift key after making your selections and before right clicking it works as expected. Will look into this but will get test instance up first so people can play with it in parallel with my bug fixing.

mjgallag · 2025-09-06T22:00:08Z

mit-cml/workspace-multiselect#112

mjgallag · 2025-09-08T19:03:21Z

https://arched-branch-471517-f9.uc.r.appspot.com/ here is an appspot instance for playing around with this

mjgallag · 2025-09-14T22:35:56Z

OK that bug is fixed and https://arched-branch-471517-f9.uc.r.appspot.com/ has been updated. Also there is no more fork for multiselect. I have marked this ready for review. I expect more bugs will probably be found but I think it's ready for more eyes.

mjgallag · 2025-09-16T20:05:45Z

I just noticed with https://appinventor.mit.edu/explore/tips/typeblocking the blocks are landing on top of each other in this branch instead of staggered like on master. @josmas I think I am going to try to integrate your plugin https://github.com/josmas/blockly-plugins/tree/feat/typeblocking as part of this Blockly 11 branch.

mjgallag · 2025-09-19T00:34:09Z

Nevermind I just fixed the bugs as moving to @josmas typeblocking plugin should be a separate pull. This bug lead me to fix the same bug in a few different places and also lead me to notice paste from backapck was broken, that fix was pretty interesting. In any case https://arched-branch-471517-f9.uc.r.appspot.com/ has been updated. I am off next week and a half. If anyone gets around to testing this please leave bugs in the comments for my return. But as of now I have fixed all I have discovered.

mjgallag · 2025-10-25T23:29:20Z

test server has been updated (https://arched-branch-471517-f9.uc.r.appspot.com/)

google-admin/blockly@61bbd7d#diff-8b0daaa052b7778349015c05366c842fed99911b561a267a30894cc9bb27a419L191-R191

google-admin/blockly@61bbd7d#diff-5175ae7b6cd103f9910b04fab3e7c4b2007b60078a396af66e63a6e8c63e6aceL209-R212 https://github.com/google/blockly/blob/blockly-v11.2.2/core/workspace_svg.ts#L1009

https://github.com/google/blockly/blob/blockly-v11.2.2/core/workspace_svg.ts#L708

google-admin/blockly@ab9825c#diff-5175ae7b6cd103f9910b04fab3e7c4b2007b60078a396af66e63a6e8c63e6aceL214-R214 https://github.com/google/blockly/blob/blockly-v11.2.2/core/workspace_svg.ts#L993

google-admin/blockly@85013f8#diff-dd85563e074ebb74e4c34eee01568971430f3cb7a6b846feef8044ad8d5dcd61L54-R54 https://github.com/google/blockly/blob/blockly-v11.2.2/core/connection.ts#L428

https://github.com/google/blockly/blob/blockly-v11.2.2/core/field_dropdown.ts#L403

google-admin/blockly@c458d63#diff-af2458fcf0c5427418a18bfcc195a5f27fb6177b212fdc523f31c077819035f1L91-R91

https://github.com/google/blockly/blob/blockly-v11.2.2/core/connection.ts#L177

https://github.com/google/blockly/blob/blockly-v11.2.2/core/field.ts#L291

google-admin/blockly@2f74ce8#diff-7eb8337e1180eb397247bb8e8f91ac5f1d94e06d6518261ff71d28f664b0bef9L48 google-admin/blockly@2f74ce8#diff-aeb28553e3f549c3f6fcdeb09b161c70732f73df152f7e7dccd36fe535fc49f0R311

google-admin/blockly@f95af36#diff-7eb8337e1180eb397247bb8e8f91ac5f1d94e06d6518261ff71d28f664b0bef9L66-R66

google-admin/blockly@520aa60#diff-c31ad3fa2aed6dafcf75d583f81f27b4349b02e43e84efdf900f124ab61ddaf0L821-L834

ewpatton@adb36a1#diff-d6c83b0ea3d0ef4407d96f84b16abe7f23946f3ed1c49739d849535bd5e6ed49L615-R589 mit-cml@932d4e5

mit-cml@d1069a8#diff-d11e4c81369708b9a6f58d678bdfdeae3bc68a935c68e783e080c8d0c0deec3eR425-R504

block.isEditable() = block.editable && !block.isDeadOrDying() && !workspace.options.readOnly block.isOwnEditable() = block.editable

…8-60a434d

mit-cml@0048cfa#diff-e39a30013d3a818e41841c354413dc7d09712ca0b620188f5a1f6c02e835e643

google-admin/blockly@33a0cc9 mit-cml@94be1e2 mit-cml@692d4212f#diff-3bd47a7ff008314613b60ad2976ff2cd5b346edbc51b7284331bddcecb4b8bd5L684-R684 https://github.com/google/blockly/blob/blockly-v11.2.2/core/workspace_svg.ts#L1739-L1750

mit-cml@1bbfcd0 google/blockly@9e98df9 google/blockly@66fd055

mit-cml@932d4e5 ewpatton@2398fe4

mjgallag · 2025-11-06T15:44:15Z

all known issues are resolved, test server is updated https://arched-branch-471517-f9.uc.r.appspot.com

mjgallag · 2025-11-06T17:59:36Z

updated test instance to F2 (512 MB RAM, 1.2 GHz CPU)

mjgallag · 2025-11-06T18:32:21Z

Other things could certainly be broken but this is some places where our code has needed to be fixed so far:

block warnings & errors
variables & procedures
multiselect (copy/paste etc...)
backpack
collapse/expand

mjgallag force-pushed the update-to-blockly-11 branch from 8eb92fc to 785162b Compare September 11, 2025 14:57

mjgallag mentioned this pull request Sep 13, 2025

Preserve multiselection when shift held on right click mit-cml/workspace-multiselect#117

Merged

1 task

mjgallag force-pushed the update-to-blockly-11 branch 2 times, most recently from aba67f3 to ca30347 Compare September 14, 2025 21:59

mjgallag marked this pull request as ready for review September 14, 2025 22:33

mjgallag requested a review from a team September 16, 2025 15:00

mjgallag force-pushed the update-to-blockly-11 branch 2 times, most recently from 9e5b36b to 4903e4d Compare September 19, 2025 00:12

mjgallag force-pushed the update-to-blockly-11 branch from 4903e4d to 679af08 Compare September 19, 2025 02:21

mjgallag mentioned this pull request Sep 19, 2025

replace color picked by color wheel #762

Open

mjgallag added this to Blockly v11 Update Oct 10, 2025

mjgallag moved this to In Review in Blockly v11 Update Oct 10, 2025

mjgallag mentioned this pull request Oct 16, 2025

Add Blockly TypeBlocking plugin #3625

Open

12 tasks

mjgallag force-pushed the update-to-blockly-11 branch from 679af08 to 1ab15c3 Compare October 16, 2025 23:18

mjgallag mentioned this pull request Oct 21, 2025

Fix ant BlocklyTest dependencies #3626

Closed

12 tasks

mjgallag force-pushed the update-to-blockly-11 branch 2 times, most recently from e80831a to 0499194 Compare October 23, 2025 00:30

mjgallag mentioned this pull request Oct 24, 2025

Remove dead BlockSvg extensions code #3630

Closed

12 tasks

mjgallag added 26 commits November 5, 2025 17:07

Change BlockMove currentLocation_ to currentLocation

3de6acd

google-admin/blockly@61bbd7d#diff-8b0daaa052b7778349015c05366c842fed99911b561a267a30894cc9bb27a419L191-R191

Change WorkspaceSvg toolbox_ to getToolbox()

e330c5f

google-admin/blockly@61bbd7d#diff-5175ae7b6cd103f9910b04fab3e7c4b2007b60078a396af66e63a6e8c63e6aceL209-R212 https://github.com/google/blockly/blob/blockly-v11.2.2/core/workspace_svg.ts#L1009

Change WorkspaceSvg svgGroup_ to getSvgGroup()

8a0af4e

https://github.com/google/blockly/blob/blockly-v11.2.2/core/workspace_svg.ts#L708

Change WorkspaceSvg flyout_ to getFlyout()

c2a8802

google-admin/blockly@ab9825c#diff-5175ae7b6cd103f9910b04fab3e7c4b2007b60078a396af66e63a6e8c63e6aceL214-R214 https://github.com/google/blockly/blob/blockly-v11.2.2/core/workspace_svg.ts#L993

Change Connection check_ to getCheck()

de3cb8d

google-admin/blockly@85013f8#diff-dd85563e074ebb74e4c34eee01568971430f3cb7a6b846feef8044ad8d5dcd61L54-R54 https://github.com/google/blockly/blob/blockly-v11.2.2/core/connection.ts#L428

Change FieldDropdown menuGenerator_() to getOptions()

0de27eb

https://github.com/google/blockly/blob/blockly-v11.2.2/core/field_dropdown.ts#L403

Change FieldDropdown selectedOption_ to selectedOption

1547cb2

google-admin/blockly@c458d63#diff-af2458fcf0c5427418a18bfcc195a5f27fb6177b212fdc523f31c077819035f1L91-R91

Change Connection sourceBlock_ to getSourceBlock()

48fe71d

https://github.com/google/blockly/blob/blockly-v11.2.2/core/connection.ts#L177

Change Field sourceBlock_ to getSourceBlock()

f278c01

https://github.com/google/blockly/blob/blockly-v11.2.2/core/field.ts#L291

Change Mutator workspace_ to getWorkspace()

d42bb29

google-admin/blockly@2f74ce8#diff-7eb8337e1180eb397247bb8e8f91ac5f1d94e06d6518261ff71d28f664b0bef9L48 google-admin/blockly@2f74ce8#diff-aeb28553e3f549c3f6fcdeb09b161c70732f73df152f7e7dccd36fe535fc49f0R311

Change MutatorIcon rootBlock_ to rootBlock

7e5ef81

google-admin/blockly@f95af36#diff-7eb8337e1180eb397247bb8e8f91ac5f1d94e06d6518261ff71d28f664b0bef9L66-R66

Change Field setText() to setValue()

053938f

google-admin/blockly@520aa60#diff-c31ad3fa2aed6dafcf75d583f81f27b4349b02e43e84efdf900f124ab61ddaf0L821-L834

Remove unused AI.FieldTextBlockInput class

d8912da

ewpatton@adb36a1#diff-d6c83b0ea3d0ef4407d96f84b16abe7f23946f3ed1c49739d849535bd5e6ed49L615-R589 mit-cml@932d4e5

Remove unused Blockly.BlockSvg.prototype.setErrorText()

5626d7a

mit-cml@d1069a8#diff-d11e4c81369708b9a6f58d678bdfdeae3bc68a935c68e783e080c8d0c0deec3eR425-R504

Change Block isOwnEditable() to isEditable()

6092e83

block.isEditable() = block.editable && !block.isDeadOrDying() && !workspace.options.readOnly block.isOwnEditable() = block.editable

Update to @mit-app-inventor/blockly-block-lexical-variables pr81-a6173a4

0b31269

Update to @mit-app-inventor/blockly-plugin-workspace-multiselect pr11…

7dc48ba

…8-60a434d

Add Procedures & Variables tests

b8b7b42

Add Multiselect tests

90d2c31

Clear selected blocks in test setup

2bab0e0

Finish update to Blockly v11.2.2

54e37e1

Update to Blockly v11.2.2-mit-cml.pr11.0

5a31b65

Restore dark mode theme sprites.png

cd259dc

mit-cml@0048cfa#diff-e39a30013d3a818e41841c354413dc7d09712ca0b620188f5a1f6c02e835e643

Remove collapsed block fixes now in Blockly

c27224b

mit-cml@1bbfcd0 google/blockly@9e98df9 google/blockly@66fd055

Remove commented out WorkspaceSvg overrides

5af8909

mit-cml@932d4e5 ewpatton@2398fe4

mjgallag force-pushed the update-to-blockly-11 branch from bae229b to 5af8909 Compare November 6, 2025 01:16

Uh oh!

Update to Blockly 11 #3588

Are you sure you want to change the base?

Update to Blockly 11 #3588

Conversation

mjgallag commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mjgallag commented Sep 5, 2025

Uh oh!

ewpatton commented Sep 5, 2025 via email

Uh oh!

mjgallag commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mjgallag commented Sep 6, 2025

Uh oh!

mjgallag commented Sep 6, 2025

Uh oh!

mjgallag commented Sep 6, 2025

Uh oh!

mjgallag commented Sep 6, 2025

Uh oh!

mjgallag commented Sep 8, 2025

Uh oh!

mjgallag commented Sep 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mjgallag commented Sep 16, 2025

Uh oh!

mjgallag commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mjgallag commented Oct 25, 2025

Uh oh!

mjgallag commented Nov 6, 2025

Uh oh!

mjgallag commented Nov 6, 2025

Uh oh!

mjgallag commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mjgallag commented Sep 5, 2025 •

edited

Loading

mjgallag commented Sep 5, 2025 •

edited

Loading

mjgallag commented Sep 14, 2025 •

edited

Loading

mjgallag commented Sep 19, 2025 •

edited

Loading